From: Francesco Chemolli Date: Tue, 4 Sep 2012 14:38:44 +0000 (+0200) Subject: Renamed struct peer to class CachePeer. X-Git-Tag: sourceformat-review-1~6^2~27 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a3c6762c3febaf85f97ec24a3fe4094d564186b1;p=thirdparty%2Fsquid.git Renamed struct peer to class CachePeer. --- diff --git a/src/PeerDigest.h b/src/PeerDigest.h index d295a9cd9c..00df4d02ad 100644 --- a/src/PeerDigest.h +++ b/src/PeerDigest.h @@ -92,7 +92,7 @@ public: void *operator new (size_t); void operator delete(void *); - struct peer *peer; /**< pointer back to peer structure, argh */ + CachePeer *peer; /**< pointer back to peer structure, argh */ CacheDigest *cd; /**< actual digest structure */ String host; /**< copy of peer->host */ const char *req_result; /**< text status of the last request */ @@ -131,7 +131,7 @@ private: extern const Version CacheDigestVer; -extern PeerDigest *peerDigestCreate(peer * p); +extern PeerDigest *peerDigestCreate(CachePeer * p); extern void peerDigestNeeded(PeerDigest * pd); extern void peerDigestNotePeerGone(PeerDigest * pd); extern void peerDigestStatsReport(const PeerDigest * pd, StoreEntry * e); diff --git a/src/PeerSelectState.h b/src/PeerSelectState.h index 63c76b2e5a..e589e6cf1a 100644 --- a/src/PeerSelectState.h +++ b/src/PeerSelectState.h @@ -51,18 +51,18 @@ SQUIDCEXTERN void peerSelect(Comm::ConnectionList *, HttpRequest *, StoreEntry * SQUIDCEXTERN void peerSelectInit(void); /** - * A peer which has been selected as a possible destination. + * A CachePeer which has been selected as a possible destination. * Listed as pointers here so as to prevent duplicates being added but will * be converted to a set of IP address path options before handing back out * to the caller. * * Certain connection flags and outgoing settings will also be looked up and - * set based on the received request and peer settings before handing back. + * set based on the received request and CachePeer settings before handing back. */ class FwdServer { public: - peer *_peer; /* NULL --> origin server */ + CachePeer *_peer; /* NULL --> origin server */ hier_code code; FwdServer *next; }; @@ -86,21 +86,21 @@ public: FwdServer *servers; ///< temporary linked list of peers we will pass back. /* - * Why are these Ip::Address instead of peer *? Because a - * peer structure can become invalid during the peer selection + * Why are these Ip::Address instead of CachePeer *? Because a + * CachePeer structure can become invalid during the CachePeer selection * phase, specifically after a reconfigure. Thus we need to lookup - * the peer * based on the address when we are finally ready to - * reference the peer structure. + * the CachePeer * based on the address when we are finally ready to + * reference the CachePeer structure. */ Ip::Address first_parent_miss; Ip::Address closest_parent_miss; /* - * ->hit can be peer* because it should only be + * ->hit can be CachePeer* because it should only be * accessed during the thread when it is set */ - peer *hit; + CachePeer *hit; peer_t hit_type; ping_data ping; ACLChecklist *acl_checklist; diff --git a/src/SquidConfig.h b/src/SquidConfig.h index 96f63203f3..247223fe6e 100644 --- a/src/SquidConfig.h +++ b/src/SquidConfig.h @@ -246,7 +246,7 @@ public: wordlist *hierarchy_stoplist; wordlist *mcast_group_list; wordlist *dns_nameservers; - peer *peers; + CachePeer *peers; int npeers; struct { diff --git a/src/acl/FilledChecklist.h b/src/acl/FilledChecklist.h index 6c926d85ed..fef5bc1d68 100644 --- a/src/acl/FilledChecklist.h +++ b/src/acl/FilledChecklist.h @@ -52,7 +52,7 @@ public: Ip::Address src_addr; Ip::Address dst_addr; Ip::Address my_addr; - struct peer *dst_peer; + CachePeer *dst_peer; char *dst_rdns; HttpRequest *request; diff --git a/src/cache_cf.cc b/src/cache_cf.cc index 6810248c3f..0c094891a1 100644 --- a/src/cache_cf.cc +++ b/src/cache_cf.cc @@ -149,7 +149,7 @@ static void free_ecap_service_type(Adaptation::Ecap::Config *); static peer_t parseNeighborType(const char *s); -CBDATA_TYPE(peer); +CBDATA_TYPE(CachePeer); static const char *const T_MILLISECOND_STR = "millisecond"; static const char *const T_SECOND_STR = "second"; @@ -919,7 +919,7 @@ configDoConfigure(void) Config.ssl_client.sslContext = sslCreateClientContext(Config.ssl_client.cert, Config.ssl_client.key, Config.ssl_client.version, Config.ssl_client.cipher, Config.ssl_client.options, Config.ssl_client.flags, Config.ssl_client.cafile, Config.ssl_client.capath, Config.ssl_client.crlfile); - for (peer *p = Config.peers; p != NULL; p = p->next) { + for (CachePeer *p = Config.peers; p != NULL; p = p->next) { if (p->use_ssl) { debugs(3, DBG_IMPORTANT, "Initializing cache_peer " << p->name << " SSL context"); p->sslContext = sslCreateClientContext(p->sslcert, p->sslkey, p->sslversion, p->sslcipher, p->ssloptions, p->sslflags, p->sslcafile, p->sslcapath, p->sslcrlfile); @@ -1966,7 +1966,7 @@ peer_type_str(const peer_t type) } static void -dump_peer(StoreEntry * entry, const char *name, peer * p) +dump_peer(StoreEntry * entry, const char *name, CachePeer * p) { domain_ping *d; domain_type *t; @@ -2066,12 +2066,12 @@ GetUdpService(void) } static void -parse_peer(peer ** head) +parse_peer(CachePeer ** head) { char *token = NULL; - peer *p; - CBDATA_INIT_TYPE_FREECB(peer, peerDestroy); - p = cbdataAlloc(peer); + CachePeer *p; + CBDATA_INIT_TYPE_FREECB(CachePeer, peerDestroy); + p = cbdataAlloc(CachePeer); p->http_port = CACHE_HTTP_PORT; p->icp.port = CACHE_ICP_PORT; p->weight = 1; @@ -2345,9 +2345,9 @@ parse_peer(peer ** head) } static void -free_peer(peer ** P) +free_peer(CachePeer ** P) { - peer *p; + CachePeer *p; while ((p = *P) != NULL) { *P = p->next; @@ -2483,7 +2483,7 @@ static void parse_peer_access(void) { char *host = NULL; - peer *p; + CachePeer *p; if (!(host = strtok(NULL, w_space))) self_destruct(); @@ -2508,7 +2508,7 @@ parse_hostdomain(void) while ((domain = strtok(NULL, list_sep))) { domain_ping *l = NULL; domain_ping **L = NULL; - peer *p; + CachePeer *p; if ((p = peerFindByName(host)) == NULL) { debugs(15, DBG_CRITICAL, "" << cfg_filename << ", line " << config_lineno << ": No cache_peer '" << host << "'"); @@ -2546,7 +2546,7 @@ parse_hostdomaintype(void) while ((domain = strtok(NULL, list_sep))) { domain_type *l = NULL; domain_type **L = NULL; - peer *p; + CachePeer *p; if ((p = peerFindByName(host)) == NULL) { debugs(15, DBG_CRITICAL, "" << cfg_filename << ", line " << config_lineno << ": No cache_peer '" << host << "'"); diff --git a/src/carp.cc b/src/carp.cc index 9f5790b92e..32ef25a5e4 100644 --- a/src/carp.cc +++ b/src/carp.cc @@ -48,14 +48,14 @@ #define ROTATE_LEFT(x, n) (((x) << (n)) | ((x) >> (32-(n)))) static int n_carp_peers = 0; -static peer **carp_peers = NULL; +static CachePeer **carp_peers = NULL; static OBJH carpCachemgr; static int peerSortWeight(const void *a, const void *b) { - const peer *const *p1 = (const peer *const *)a; - const peer *const *p2 = (const peer *const *)b; + const CachePeer *const *p1 = (const CachePeer *const *)a; + const CachePeer *const *p2 = (const CachePeer *const *)b; return (*p1)->weight - (*p2)->weight; } @@ -72,8 +72,8 @@ carpInit(void) int K; int k; double P_last, X_last, Xn; - peer *p; - peer **P; + CachePeer *p; + CachePeer **P; char *t; /* Clean up */ @@ -106,7 +106,7 @@ carpInit(void) if (n_carp_peers == 0) return; - carp_peers = (peer **)xcalloc(n_carp_peers, sizeof(*carp_peers)); + carp_peers = (CachePeer **)xcalloc(n_carp_peers, sizeof(*carp_peers)); /* Build a list of the found peers and calculate hashes and load factors */ for (P = carp_peers, p = Config.peers; p; p = p->next) { @@ -168,12 +168,12 @@ carpInit(void) } } -peer * +CachePeer * carpSelectParent(HttpRequest * request) { int k; - peer *p = NULL; - peer *tp; + CachePeer *p = NULL; + CachePeer *tp; unsigned int user_hash = 0; unsigned int combined_hash; double score; @@ -185,7 +185,7 @@ carpSelectParent(HttpRequest * request) /* calculate hash key */ debugs(39, 2, "carpSelectParent: Calculating hash for " << urlCanonical(request)); - /* select peer */ + /* select CachePeer */ for (k = 0; k < n_carp_peers; ++k) { String key; tp = carp_peers[k]; @@ -251,7 +251,7 @@ carpSelectParent(HttpRequest * request) static void carpCachemgr(StoreEntry * sentry) { - peer *p; + CachePeer *p; int sumfetches = 0; storeAppendPrintf(sentry, "%24s %10s %10s %10s %10s\n", "Hostname", diff --git a/src/carp.h b/src/carp.h index be7be8fce6..7bbaf71d41 100644 --- a/src/carp.h +++ b/src/carp.h @@ -33,10 +33,10 @@ #ifndef SQUID_CARP_H_ #define SQUID_CARP_H_ -class peer; +class CachePeer; class HttpRequest; extern void carpInit(void); -extern peer *carpSelectParent(HttpRequest *); +extern CachePeer *carpSelectParent(HttpRequest *); #endif /* SQUID_CARP_H_ */ diff --git a/src/client_side.cc b/src/client_side.cc index 8a30a86851..4be187455a 100644 --- a/src/client_side.cc +++ b/src/client_side.cc @@ -1268,7 +1268,7 @@ ClientSocketContext::buildRangeHeader(HttpReply * rep) else if (rep->content_length != http->memObject()->getReply()->content_length) range_err = "INCONSISTENT length"; /* a bug? */ - /* hits only - upstream peer determines correct behaviour on misses, and client_side_reply determines + /* hits only - upstream CachePeer determines correct behaviour on misses, and client_side_reply determines * hits candidates */ else if (logTypeIsATcpHit(http->logType) && http->request->header.has(HDR_IF_RANGE) && !clientIfRangeMatch(http, rep)) @@ -3147,7 +3147,7 @@ ConnStateData::abortChunkedRequestBody(const err_type error) repContext->setReplyToError(error, scode, repContext->http->request->method, repContext->http->uri, - peer, + CachePeer, repContext->http->request, in.buf, NULL); context->pullData(); @@ -3216,7 +3216,7 @@ ConnStateData::requestTimeout(const CommTimeoutCbParams &io) clientReplyContext *repContext = dynamic_cast(node->data.getRaw()); assert (repContext); repContext->setReplyToError(ERR_LIFETIME_EXP, - HTTP_REQUEST_TIMEOUT, METHOD_NONE, "N/A", &peer.sin_addr, + HTTP_REQUEST_TIMEOUT, METHOD_NONE, "N/A", &CachePeer.sin_addr, NULL, NULL, NULL); /* No requests can be outstanded */ assert(chr == NULL); @@ -3891,7 +3891,7 @@ ConnStateData::getSslContextDone(SSL_CTX * sslContext, bool isNew) // commSetConnTimeout() was called for this request before we switched. - // Disable the client read handler until peer selection is complete + // Disable the client read handler until CachePeer selection is complete Comm::SetSelect(clientConnection->fd, COMM_SELECT_READ, NULL, NULL, 0); Comm::SetSelect(clientConnection->fd, COMM_SELECT_READ, clientNegotiateSSL, this, 0); switchedToHttps_ = true; @@ -4428,7 +4428,7 @@ ConnStateData::clientPinnedConnectionClosed(const CommCloseCbParams &io) } void -ConnStateData::pinConnection(const Comm::ConnectionPointer &pinServer, HttpRequest *request, struct peer *aPeer, bool auth) +ConnStateData::pinConnection(const Comm::ConnectionPointer &pinServer, HttpRequest *request, CachePeer *aPeer, bool auth) { char desc[FD_DESC_SZ]; @@ -4474,7 +4474,7 @@ ConnStateData::pinConnection(const Comm::ConnectionPointer &pinServer, HttpReque } const Comm::ConnectionPointer -ConnStateData::validatePinnedConnection(HttpRequest *request, const struct peer *aPeer) +ConnStateData::validatePinnedConnection(HttpRequest *request, const CachePeer *aPeer) { debugs(33, 7, HERE << pinning.serverConnection); diff --git a/src/client_side.h b/src/client_side.h index 62a916cffa..24337153f2 100644 --- a/src/client_side.h +++ b/src/client_side.h @@ -259,7 +259,7 @@ public: int port; /* port of pinned connection */ bool pinned; /* this connection was pinned */ bool auth; /* pinned for www authentication */ - struct peer *peer; /* peer the connection goes via */ + CachePeer *peer; /* CachePeer the connection goes via */ AsyncCall::Pointer closeHandler; /*The close handler for pinned server side connection*/ } pinning; @@ -290,23 +290,23 @@ public: /** * Correlate the current ConnStateData object with the pinning_fd socket descriptor. */ - void pinConnection(const Comm::ConnectionPointer &pinServerConn, HttpRequest *request, struct peer *peer, bool auth); + void pinConnection(const Comm::ConnectionPointer &pinServerConn, HttpRequest *request, CachePeer *peer, bool auth); /** - * Decorrelate the ConnStateData object from its pinned peer + * Decorrelate the ConnStateData object from its pinned CachePeer */ void unpinConnection(); /** * Checks if there is pinning info if it is valid. It can close the server side connection * if pinned info is not valid. \param request if it is not NULL also checks if the pinning info refers to the request client side HttpRequest - \param peer if it is not NULL also check if the peer is the pinning peer + \param CachePeer if it is not NULL also check if the CachePeer is the pinning CachePeer \return The details of the server side connection (may be closed if failures were present). */ - const Comm::ConnectionPointer validatePinnedConnection(HttpRequest *request, const struct peer *peer); + const Comm::ConnectionPointer validatePinnedConnection(HttpRequest *request, const CachePeer *peer); /** - * returts the pinned peer if exists, NULL otherwise + * returts the pinned CachePeer if exists, NULL otherwise */ - struct peer *pinnedPeer() const {return pinning.peer;} + CachePeer *pinnedPeer() const {return pinning.peer;} bool pinnedAuth() const {return pinning.auth;} // pining related comm callbacks diff --git a/src/comm/ConnOpener.cc b/src/comm/ConnOpener.cc index e21b7730af..080e7f1ca3 100644 --- a/src/comm/ConnOpener.cc +++ b/src/comm/ConnOpener.cc @@ -204,11 +204,11 @@ Comm::ConnOpener::connected() /* * stats.conn_open is used to account for the number of - * connections that we have open to the peer, so we can limit + * connections that we have open to the CachePeer, so we can limit * based on the max-conn option. We need to increment here, * even if the connection may fail. */ - if (peer *peer=(conn_->getPeer())) + if (CachePeer *peer=(conn_->getPeer())) ++peer->stats.conn_open; lookupLocalAddress(); diff --git a/src/comm/Connection.cc b/src/comm/Connection.cc index c0e8a34739..50eaa814f4 100644 --- a/src/comm/Connection.cc +++ b/src/comm/Connection.cc @@ -18,7 +18,7 @@ Comm::Connection::Connection() : fd(-1), tos(0), flags(COMM_NONBLOCKING), - _peer(NULL) + peer_(NULL) { *rfc931 = 0; // quick init the head. the rest does not matter. } @@ -32,7 +32,7 @@ Comm::Connection::~Connection() close(); } - cbdataReferenceDone(_peer); + cbdataReferenceDone(peer_); } Comm::ConnectionPointer @@ -49,8 +49,8 @@ Comm::Connection::copyDetails() const // ensure FD is not open in the new copy. c->fd = -1; - // ensure we have a cbdata reference to _peer not a straight ptr copy. - c->_peer = cbdataReference(getPeer()); + // ensure we have a cbdata reference to peer_ not a straight ptr copy. + c->peer_ = cbdataReference(getPeer()); return c; } @@ -61,29 +61,29 @@ Comm::Connection::close() if (isOpen()) { comm_close(fd); fd = -1; - if (peer *p=getPeer()) + if (CachePeer *p=getPeer()) -- p->stats.conn_open; } } -peer * +CachePeer * Comm::Connection::getPeer() const { - if (cbdataReferenceValid(_peer)) - return _peer; + if (cbdataReferenceValid(peer_)) + return peer_; return NULL; } void -Comm::Connection::setPeer(peer *p) +Comm::Connection::setPeer(CachePeer *p) { /* set to self. nothing to do. */ if (getPeer() == p) return; - cbdataReferenceDone(_peer); + cbdataReferenceDone(peer_); if (p) { - _peer = cbdataReference(p); + peer_ = cbdataReference(p); } } diff --git a/src/comm/Connection.h b/src/comm/Connection.h index ec5b9fc67a..1f15a00463 100644 --- a/src/comm/Connection.h +++ b/src/comm/Connection.h @@ -56,7 +56,7 @@ #include #endif -struct peer; +class CachePeer; namespace Comm { @@ -108,16 +108,16 @@ public: /** determine whether this object describes an active connection or not. */ bool isOpen() const { return (fd >= 0); } - /** retrieve the peer pointer for use. + /** retrieve the CachePeer pointer for use. * The caller is responsible for all CBDATA operations regarding the * used of the pointer returned. */ - peer * getPeer() const; + CachePeer * getPeer() const; - /** alter the stored peer pointer. - * Perform appropriate CBDATA operations for locking the peer pointer + /** alter the stored CachePeer pointer. + * Perform appropriate CBDATA operations for locking the CachePeer pointer */ - void setPeer(peer * p); + void setPeer(CachePeer * p); private: /** These objects may not be exactly duplicated. Use copyDetails() instead. */ @@ -156,12 +156,8 @@ public: #endif private: - // XXX: we need to call this member peer_ but the struct peer_ global type - // behind peer* clashes despite our private Comm:: namespace - // (it being global gets inherited here too). - /** cache_peer data object (if any) */ - peer *_peer; + CachePeer *peer_; }; }; // namespace Comm diff --git a/src/forward.cc b/src/forward.cc index 072286f6a8..e287cbfe92 100644 --- a/src/forward.cc +++ b/src/forward.cc @@ -762,7 +762,7 @@ FwdState::initiateSSL() { SSL *ssl; SSL_CTX *sslContext = NULL; - const peer *peer = serverConnection()->getPeer(); + const CachePeer *peer = serverConnection()->getPeer(); int fd = serverConnection()->fd; if (peer) { diff --git a/src/htcp.cc b/src/htcp.cc index a1d2ae7699..7a5f2baacf 100644 --- a/src/htcp.cc +++ b/src/htcp.cc @@ -1308,7 +1308,7 @@ htcpHandleClr(htcpDataHeader * hdr, char *buf, int sz, Ip::Address &from) static void htcpForwardClr(char *buf, int sz) { - peer *p; + CachePeer *p; for (p = Config.peers; p; p = p->next) { if (!p->options.htcp) { @@ -1551,7 +1551,7 @@ htcpIncomingConnectionOpened(const Comm::ConnectionPointer &conn, int) } int -htcpQuery(StoreEntry * e, HttpRequest * req, peer * p) +htcpQuery(StoreEntry * e, HttpRequest * req, CachePeer * p) { cache_key *save_key; static char pkt[8192]; @@ -1604,10 +1604,10 @@ htcpQuery(StoreEntry * e, HttpRequest * req, peer * p) } /* - * Send an HTCP CLR message for a specified item to a given peer. + * Send an HTCP CLR message for a specified item to a given CachePeer. */ void -htcpClear(StoreEntry * e, const char *uri, HttpRequest * req, const HttpRequestMethod &method, peer * p, htcp_clr_reason reason) +htcpClear(StoreEntry * e, const char *uri, HttpRequest * req, const HttpRequestMethod &method, CachePeer * p, htcp_clr_reason reason) { static char pkt[8192]; ssize_t pktlen; diff --git a/src/htcp.h b/src/htcp.h index 368709ff5b..2907d3f774 100644 --- a/src/htcp.h +++ b/src/htcp.h @@ -79,10 +79,10 @@ SQUIDCEXTERN void htcpOpenPorts(void); * Don't wait for a reply or count in stats as sent. * \retval -1 Error sending request. */ -SQUIDCEXTERN int htcpQuery(StoreEntry * e, HttpRequest * req, peer * p); +SQUIDCEXTERN int htcpQuery(StoreEntry * e, HttpRequest * req, CachePeer * p); /// \ingroup ServerProtocolHTCP -SQUIDCEXTERN void htcpClear(StoreEntry * e, const char *uri, HttpRequest * req, const HttpRequestMethod &method, peer * p, htcp_clr_reason reason); +SQUIDCEXTERN void htcpClear(StoreEntry * e, const char *uri, HttpRequest * req, const HttpRequestMethod &method, CachePeer * p, htcp_clr_reason reason); /// \ingroup ServerProtocolHTCP SQUIDCEXTERN void htcpSocketShutdown(void); diff --git a/src/http.h b/src/http.h index 5b7f0a4172..1c78faf4c3 100644 --- a/src/http.h +++ b/src/http.h @@ -61,7 +61,7 @@ public: virtual void maybeReadVirginBody(); // read response data from the network int cacheableReply(); - peer *_peer; /* peer request made to */ + CachePeer *_peer; /* CachePeer request made to */ int eof; /* reached end-of-object? */ int lastChunk; /* reached last chunk of a chunk-encoded reply */ http_state_flags flags; diff --git a/src/icmp/net_db.cc b/src/icmp/net_db.cc index 5cde2d00dc..c0b1c52816 100644 --- a/src/icmp/net_db.cc +++ b/src/icmp/net_db.cc @@ -81,7 +81,7 @@ typedef enum { } netdb_conn_state_t; typedef struct { - peer *p; + CachePeer *p; StoreEntry *e; store_client *sc; HttpRequest *r; @@ -105,7 +105,7 @@ static void netdbHostDelete(const net_db_name * x); static void netdbPurgeLRU(void); static netdbEntry *netdbLookupHost(const char *key); static net_db_peer *netdbPeerByName(const netdbEntry * n, const char *); -static net_db_peer *netdbPeerAdd(netdbEntry * n, peer * e); +static net_db_peer *netdbPeerAdd(netdbEntry * n, CachePeer * e); static const char *netdbPeerName(const char *name); static IPH netdbSendPing; static QS sortPeerByRtt; @@ -116,7 +116,7 @@ static FREE netdbFreeNetdbEntry; static STCB netdbExchangeHandleReply; static void netdbExchangeDone(void *); -/* We have to keep a local list of peer names. The Peers structure +/* We have to keep a local list of CachePeer names. The Peers structure * gets freed during a reconfigure. We want this database to * remain persisitent, so _net_db_peer->peername points into this * linked list */ @@ -421,7 +421,7 @@ netdbPeerByName(const netdbEntry * n, const char *peername) } static net_db_peer * -netdbPeerAdd(netdbEntry * n, peer * e) +netdbPeerAdd(netdbEntry * n, CachePeer * e) { net_db_peer *p; net_db_peer *o; @@ -1123,7 +1123,7 @@ netdbHostData(const char *host, int *samp, int *rtt, int *hops) } void -netdbUpdatePeer(HttpRequest * r, peer * e, int irtt, int ihops) +netdbUpdatePeer(HttpRequest * r, CachePeer * e, int irtt, int ihops) { #if USE_ICMP netdbEntry *n; @@ -1159,7 +1159,7 @@ netdbUpdatePeer(HttpRequest * r, peer * e, int irtt, int ihops) } void -netdbExchangeUpdatePeer(Ip::Address &addr, peer * e, double rtt, double hops) +netdbExchangeUpdatePeer(Ip::Address &addr, CachePeer * e, double rtt, double hops) { #if USE_ICMP netdbEntry *n; @@ -1313,7 +1313,7 @@ void netdbExchangeStart(void *data) { #if USE_ICMP - peer *p = (peer *)data; + CachePeer *p = (CachePeer *)data; char *uri; netdbExchangeState *ex; StoreIOBuffer tempBuffer; @@ -1355,11 +1355,11 @@ netdbExchangeStart(void *data) #endif } -peer * +CachePeer * netdbClosestParent(HttpRequest * request) { #if USE_ICMP - peer *p = NULL; + CachePeer *p = NULL; netdbEntry *n; const ipcache_addrs *ia; net_db_peer *h; diff --git a/src/icmp/net_db.h b/src/icmp/net_db.h index 8282ad4d4f..b5b341174f 100644 --- a/src/icmp/net_db.h +++ b/src/icmp/net_db.h @@ -9,7 +9,7 @@ class Address; class StoreEntry; class HttpRequest; -/* for struct peer */ +/* for CachePeer */ #include "structs.h" SQUIDCEXTERN void netdbInit(void); @@ -21,14 +21,14 @@ void netdbDump(StoreEntry *); SQUIDCEXTERN void netdbFreeMemory(void); SQUIDCEXTERN int netdbHostHops(const char *host); SQUIDCEXTERN int netdbHostRtt(const char *host); -SQUIDCEXTERN void netdbUpdatePeer(HttpRequest *, peer * e, int rtt, int hops); +SQUIDCEXTERN void netdbUpdatePeer(HttpRequest *, CachePeer * e, int rtt, int hops); SQUIDCEXTERN void netdbDeleteAddrNetwork(Ip::Address &addr); SQUIDCEXTERN void netdbBinaryExchange(StoreEntry *); SQUIDCEXTERN void netdbExchangeStart(void *); -SQUIDCEXTERN void netdbExchangeUpdatePeer(Ip::Address &, peer *, double, double); -SQUIDCEXTERN peer *netdbClosestParent(HttpRequest *); +SQUIDCEXTERN void netdbExchangeUpdatePeer(Ip::Address &, CachePeer *, double, double); +SQUIDCEXTERN CachePeer *netdbClosestParent(HttpRequest *); SQUIDCEXTERN void netdbHostData(const char *host, int *samp, int *rtt, int *hops); #endif /* ICMP_NET_DB_H */ diff --git a/src/neighbors.cc b/src/neighbors.cc index ce4cc0dbcd..eadbdfe637 100644 --- a/src/neighbors.cc +++ b/src/neighbors.cc @@ -65,35 +65,35 @@ /* count mcast group peers every 15 minutes */ #define MCAST_COUNT_RATE 900 -bool peerAllowedToUse(const peer *, HttpRequest *); -static int peerWouldBePinged(const peer *, HttpRequest *); -static void neighborRemove(peer *); -static void neighborAlive(peer *, const MemObject *, const icp_common_t *); +bool peerAllowedToUse(const CachePeer *, HttpRequest *); +static int peerWouldBePinged(const CachePeer *, HttpRequest *); +static void neighborRemove(CachePeer *); +static void neighborAlive(CachePeer *, const MemObject *, const icp_common_t *); #if USE_HTCP -static void neighborAliveHtcp(peer *, const MemObject *, const htcpReplyData *); +static void neighborAliveHtcp(CachePeer *, const MemObject *, const htcpReplyData *); #endif -static void neighborCountIgnored(peer *); +static void neighborCountIgnored(CachePeer *); static void peerRefreshDNS(void *); static IPH peerDNSConfigure; -static bool peerProbeConnect(peer *); +static bool peerProbeConnect(CachePeer *); static CNCB peerProbeConnectDone; static void peerCountMcastPeersDone(void *data); static void peerCountMcastPeersStart(void *data); -static void peerCountMcastPeersSchedule(peer * p, time_t when); +static void peerCountMcastPeersSchedule(CachePeer * p, time_t when); static IRCB peerCountHandleIcpReply; static void neighborIgnoreNonPeer(const Ip::Address &, icp_opcode); static OBJH neighborDumpPeers; static OBJH neighborDumpNonPeers; -static void dump_peers(StoreEntry * sentry, peer * peers); +static void dump_peers(StoreEntry * sentry, CachePeer * peers); static unsigned short echo_port; static int NLateReplies = 0; -static peer *first_ping = NULL; +static CachePeer *first_ping = NULL; const char * -neighborTypeStr(const peer * p) +neighborTypeStr(const CachePeer * p) { if (p->type == PEER_NONE) return "Non-Peer"; @@ -107,12 +107,12 @@ neighborTypeStr(const peer * p) return "Parent"; } -peer * +CachePeer * whichPeer(const Ip::Address &from) { int j; - peer *p = NULL; + CachePeer *p = NULL; debugs(15, 3, "whichPeer: from " << from); for (p = Config.peers; p; p = p->next) { @@ -127,7 +127,7 @@ whichPeer(const Ip::Address &from) } peer_t -neighborType(const peer * p, const HttpRequest * request) +neighborType(const CachePeer * p, const HttpRequest * request) { const domain_type *d = NULL; @@ -150,7 +150,7 @@ neighborType(const peer * p, const HttpRequest * request) * \return Whether it is appropriate to fetch REQUEST from PEER. */ bool -peerAllowedToUse(const peer * p, HttpRequest * request) +peerAllowedToUse(const CachePeer * p, HttpRequest * request) { const domain_ping *d = NULL; @@ -176,7 +176,7 @@ peerAllowedToUse(const peer * p, HttpRequest * request) } // CONNECT requests are proxy requests. Not to be forwarded to origin servers. - // Unless the destination port matches, in which case we MAY perform a 'DIRECT' to this peer. + // Unless the destination port matches, in which case we MAY perform a 'DIRECT' to this CachePeer. if (p->options.originserver && request->method == METHOD_CONNECT && request->port != p->in_addr.GetPort()) return false; @@ -217,9 +217,9 @@ peerAllowedToUse(const peer * p, HttpRequest * request) return (checklist.fastCheck() == ACCESS_ALLOWED); } -/* Return TRUE if it is okay to send an ICP request to this peer. */ +/* Return TRUE if it is okay to send an ICP request to this CachePeer. */ static int -peerWouldBePinged(const peer * p, HttpRequest * request) +peerWouldBePinged(const CachePeer * p, HttpRequest * request) { if (p->icp.port == 0) return 0; @@ -255,9 +255,9 @@ peerWouldBePinged(const peer * p, HttpRequest * request) return 1; } -/* Return TRUE if it is okay to send an HTTP request to this peer. */ +/* Return TRUE if it is okay to send an HTTP request to this CachePeer. */ int -peerHTTPOkay(const peer * p, HttpRequest * request) +peerHTTPOkay(const CachePeer * p, HttpRequest * request) { if (p->max_conn) if (p->stats.conn_open >= p->max_conn) @@ -275,7 +275,7 @@ peerHTTPOkay(const peer * p, HttpRequest * request) int neighborsCount(HttpRequest * request) { - peer *p = NULL; + CachePeer *p = NULL; int count = 0; for (p = Config.peers; p; p = p->next) @@ -287,10 +287,10 @@ neighborsCount(HttpRequest * request) return count; } -peer * +CachePeer * getFirstUpParent(HttpRequest * request) { - peer *p = NULL; + CachePeer *p = NULL; for (p = Config.peers; p; p = p->next) { if (!neighborUp(p)) @@ -309,11 +309,11 @@ getFirstUpParent(HttpRequest * request) return p; } -peer * +CachePeer * getRoundRobinParent(HttpRequest * request) { - peer *p; - peer *q = NULL; + CachePeer *p; + CachePeer *q = NULL; for (p = Config.peers; p; p = p->next) { if (!p->options.roundrobin) @@ -348,11 +348,11 @@ getRoundRobinParent(HttpRequest * request) return q; } -peer * +CachePeer * getWeightedRoundRobinParent(HttpRequest * request) { - peer *p; - peer *q = NULL; + CachePeer *p; + CachePeer *q = NULL; int weighted_rtt; for (p = Config.peers; p; p = p->next) { @@ -415,7 +415,7 @@ peerClearRRLoop(void *data) } /** - * This gets called on startup and restart to kick off the peer round-robin + * This gets called on startup and restart to kick off the CachePeer round-robin * maintenance event. It ensures that no matter how many times its called * no more than one event is scheduled. */ @@ -432,23 +432,23 @@ peerClearRRStart(void) * Called whenever the round-robin counters need to be reset to a sane state. * So far those times are: * - On startup and reconfigure - to set the counters to sane initial settings. - * - When a peer has revived from dead, to prevent the revived peer being + * - When a CachePeer has revived from dead, to prevent the revived CachePeer being * flooded with requests which it has 'missed' during the down period. */ void peerClearRR() { - peer *p = NULL; + CachePeer *p = NULL; for (p = Config.peers; p; p = p->next) { p->rr_count = 0; } } /** - * Perform all actions when a peer is detected revived. + * Perform all actions when a CachePeer is detected revived. */ void -peerAlive(peer *p) +peerAlive(CachePeer *p) { if (p->stats.logged_state == PEER_DEAD && p->tcp_up) { debugs(15, DBG_IMPORTANT, "Detected REVIVED " << neighborTypeStr(p) << ": " << p->name); @@ -460,10 +460,10 @@ peerAlive(peer *p) p->stats.probe_start = 0; } -peer * +CachePeer * getDefaultParent(HttpRequest * request) { - peer *p = NULL; + CachePeer *p = NULL; for (p = Config.peers; p; p = p->next) { if (neighborType(p, request) != PEER_PARENT) @@ -484,23 +484,23 @@ getDefaultParent(HttpRequest * request) return NULL; } -peer * -getNextPeer(peer * p) +CachePeer * +getNextPeer(CachePeer * p) { return p->next; } -peer * +CachePeer * getFirstPeer(void) { return Config.peers; } static void -neighborRemove(peer * target) +neighborRemove(CachePeer * target) { - peer *p = NULL; - peer **P = NULL; + CachePeer *p = NULL; + CachePeer **P = NULL; p = Config.peers; P = &Config.peers; @@ -541,8 +541,8 @@ neighbors_init(void) { struct servent *sep = NULL; const char *me = getMyHostname(); - peer *thisPeer = NULL; - peer *next = NULL; + CachePeer *thisPeer = NULL; + CachePeer *next = NULL; neighborsRegisterWithCacheManager(); @@ -588,7 +588,7 @@ neighborsUdpPing(HttpRequest * request, { const char *url = entry->url(); MemObject *mem = entry->mem_obj; - peer *p = NULL; + CachePeer *p = NULL; int i; int reqnum = 0; int flags; @@ -619,7 +619,7 @@ neighborsUdpPing(HttpRequest * request, debugs(15, 5, "neighborsUdpPing: Peer " << p->host); if (!peerWouldBePinged(p, request)) - continue; /* next peer */ + continue; /* next CachePeer */ ++peers_pinged; @@ -698,8 +698,8 @@ neighborsUdpPing(HttpRequest * request, p->stats.last_query = squid_curtime; /* - * keep probe_start == 0 for a multicast peer, - * so neighborUp() never says this peer is dead. + * keep probe_start == 0 for a multicast CachePeer, + * so neighborUp() never says this CachePeer is dead. */ if ((p->type != PEER_MULTICAST) && (p->stats.probe_start == 0)) @@ -741,9 +741,9 @@ neighborsUdpPing(HttpRequest * request, return peers_pinged; } -/* lookup the digest of a given peer */ +/* lookup the digest of a given CachePeer */ lookup_t -peerDigestLookup(peer * p, HttpRequest * request) +peerDigestLookup(CachePeer * p, HttpRequest * request) { #if USE_CACHE_DIGESTS const cache_key *key = request ? storeKeyPublicByRequest(request) : NULL; @@ -783,17 +783,17 @@ peerDigestLookup(peer * p, HttpRequest * request) return LOOKUP_NONE; } -/* select best peer based on cache digests */ -peer * +/* select best CachePeer based on cache digests */ +CachePeer * neighborsDigestSelect(HttpRequest * request) { - peer *best_p = NULL; + CachePeer *best_p = NULL; #if USE_CACHE_DIGESTS int best_rtt = 0; int choice_count = 0; int ichoice_count = 0; - peer *p; + CachePeer *p; int p_rtt; int i; @@ -825,7 +825,7 @@ neighborsDigestSelect(HttpRequest * request) debugs(15, 5, "neighborsDigestSelect: peer " << p->host << " rtt: " << p_rtt); - /* is this peer better than others in terms of rtt ? */ + /* is this CachePeer better than others in terms of rtt ? */ if (!best_p || (p_rtt && p_rtt < best_rtt)) { best_p = p; best_rtt = p_rtt; @@ -848,7 +848,7 @@ neighborsDigestSelect(HttpRequest * request) } void -peerNoteDigestLookup(HttpRequest * request, peer * p, lookup_t lookup) +peerNoteDigestLookup(HttpRequest * request, CachePeer * p, lookup_t lookup) { #if USE_CACHE_DIGESTS if (p) @@ -862,7 +862,7 @@ peerNoteDigestLookup(HttpRequest * request, peer * p, lookup_t lookup) } static void -neighborAlive(peer * p, const MemObject * mem, const icp_common_t * header) +neighborAlive(CachePeer * p, const MemObject * mem, const icp_common_t * header) { peerAlive(p); ++ p->stats.pings_acked; @@ -874,7 +874,7 @@ neighborAlive(peer * p, const MemObject * mem, const icp_common_t * header) } static void -neighborUpdateRtt(peer * p, MemObject * mem) +neighborUpdateRtt(CachePeer * p, MemObject * mem) { int rtt, rtt_av_factor; @@ -899,7 +899,7 @@ neighborUpdateRtt(peer * p, MemObject * mem) #if USE_HTCP static void -neighborAliveHtcp(peer * p, const MemObject * mem, const htcpReplyData * htcp) +neighborAliveHtcp(CachePeer * p, const MemObject * mem, const htcpReplyData * htcp) { peerAlive(p); ++ p->stats.pings_acked; @@ -910,7 +910,7 @@ neighborAliveHtcp(peer * p, const MemObject * mem, const htcpReplyData * htcp) #endif static void -neighborCountIgnored(peer * p) +neighborCountIgnored(CachePeer * p) { if (p == NULL) return; @@ -920,12 +920,12 @@ neighborCountIgnored(peer * p) ++NLateReplies; } -static peer *non_peers = NULL; +static CachePeer *non_peers = NULL; static void neighborIgnoreNonPeer(const Ip::Address &from, icp_opcode opcode) { - peer *np; + CachePeer *np; for (np = non_peers; np; np = np->next) { if (np->in_addr != from) @@ -938,7 +938,7 @@ neighborIgnoreNonPeer(const Ip::Address &from, icp_opcode opcode) } if (np == NULL) { - np = (peer *)xcalloc(1, sizeof(peer)); + np = (CachePeer *)xcalloc(1, sizeof(CachePeer)); np->in_addr = from; np->icp.port = from.GetPort(); np->type = PEER_NONE; @@ -957,11 +957,11 @@ neighborIgnoreNonPeer(const Ip::Address &from, icp_opcode opcode) /* ignoreMulticastReply * * * We want to ignore replies from multicast peers if the - * * cache_host_domain rules would normally prevent the peer + * * cache_host_domain rules would normally prevent the CachePeer * * from being used */ static int -ignoreMulticastReply(peer * p, MemObject * mem) +ignoreMulticastReply(CachePeer * p, MemObject * mem) { if (p == NULL) return 0; @@ -985,7 +985,7 @@ ignoreMulticastReply(peer * p, MemObject * mem) void neighborsUdpAck(const cache_key * key, icp_common_t * header, const Ip::Address &from) { - peer *p = NULL; + CachePeer *p = NULL; StoreEntry *entry; MemObject *mem = NULL; peer_t ntype = PEER_NONE; @@ -1097,10 +1097,10 @@ neighborsUdpAck(const cache_key * key, icp_common_t * header, const Ip::Address } } -peer * +CachePeer * peerFindByName(const char *name) { - peer *p = NULL; + CachePeer *p = NULL; for (p = Config.peers; p; p = p->next) { if (!strcasecmp(name, p->name)) @@ -1110,10 +1110,10 @@ peerFindByName(const char *name) return p; } -peer * +CachePeer * peerFindByNameAndPort(const char *name, unsigned short port) { - peer *p = NULL; + CachePeer *p = NULL; for (p = Config.peers; p; p = p->next) { if (strcasecmp(name, p->name)) @@ -1129,17 +1129,17 @@ peerFindByNameAndPort(const char *name, unsigned short port) } int -neighborUp(const peer * p) +neighborUp(const CachePeer * p) { if (!p->tcp_up) { - if (!peerProbeConnect((peer *) p)) { + if (!peerProbeConnect((CachePeer *) p)) { debugs(15, 8, "neighborUp: DOWN (probed): " << p->host << " (" << p->in_addr << ")"); return 0; } } /* - * The peer can not be UP if we don't have any IP addresses + * The CachePeer can not be UP if we don't have any IP addresses * for it. */ if (0 == p->n_addresses) { @@ -1165,7 +1165,7 @@ neighborUp(const peer * p) void peerDestroy(void *data) { - peer *p = (peer *)data; + CachePeer *p = (CachePeer *)data; if (p == NULL) return; @@ -1188,7 +1188,7 @@ peerDestroy(void *data) } void -peerNoteDigestGone(peer * p) +peerNoteDigestGone(CachePeer * p) { #if USE_CACHE_DIGESTS cbdataReferenceDone(p->digest); @@ -1198,7 +1198,7 @@ peerNoteDigestGone(peer * p) static void peerDNSConfigure(const ipcache_addrs *ia, const DnsLookupDetails &, void *data) { - peer *p = (peer *)data; + CachePeer *p = (CachePeer *)data; int j; @@ -1247,7 +1247,7 @@ peerDNSConfigure(const ipcache_addrs *ia, const DnsLookupDetails &, void *data) static void peerRefreshDNS(void *data) { - peer *p = NULL; + CachePeer *p = NULL; if (eventFind(peerRefreshDNS, NULL)) eventDelete(peerRefreshDNS, NULL); @@ -1266,7 +1266,7 @@ peerRefreshDNS(void *data) } static void -peerConnectFailedSilent(peer * p) +peerConnectFailedSilent(CachePeer * p) { p->stats.last_connect_failure = squid_curtime; @@ -1285,14 +1285,14 @@ peerConnectFailedSilent(peer * p) } void -peerConnectFailed(peer *p) +peerConnectFailed(CachePeer *p) { debugs(15, DBG_IMPORTANT, "TCP connection to " << p->host << "/" << p->http_port << " failed"); peerConnectFailedSilent(p); } void -peerConnectSucceded(peer * p) +peerConnectSucceded(CachePeer * p) { if (!p->tcp_up) { debugs(15, 2, "TCP connection to " << p->host << "/" << p->http_port << " succeded"); @@ -1308,7 +1308,7 @@ peerConnectSucceded(peer * p) * peerProbeConnect will be called on dead peers by neighborUp */ static bool -peerProbeConnect(peer * p) +peerProbeConnect(CachePeer * p) { time_t ctimeout = p->connect_timeout > 0 ? p->connect_timeout : Config.Timeout.peer_connect; bool ret = (squid_curtime - p->stats.last_connect_failure) > (ctimeout * 10); @@ -1319,7 +1319,7 @@ peerProbeConnect(peer * p) if (squid_curtime - p->stats.last_connect_probe == 0) return ret;/* don't probe to often */ - /* for each IP address of this peer. find one that we can connect to and probe it. */ + /* for each IP address of this CachePeer. find one that we can connect to and probe it. */ for (int i = 0; i < p->n_addresses; ++i) { Comm::ConnectionPointer conn = new Comm::Connection; conn->remote = p->addresses[i]; @@ -1342,7 +1342,7 @@ peerProbeConnect(peer * p) static void peerProbeConnectDone(const Comm::ConnectionPointer &conn, comm_err_t status, int xerrno, void *data) { - peer *p = (peer*)data; + CachePeer *p = (CachePeer*)data; if (status == COMM_OK) { peerConnectSucceded(p); @@ -1356,7 +1356,7 @@ peerProbeConnectDone(const Comm::ConnectionPointer &conn, comm_err_t status, int } static void -peerCountMcastPeersSchedule(peer * p, time_t when) +peerCountMcastPeersSchedule(CachePeer * p, time_t when) { if (p->mcast.flags.count_event_pending) return; @@ -1372,7 +1372,7 @@ peerCountMcastPeersSchedule(peer * p, time_t when) static void peerCountMcastPeersStart(void *data) { - peer *p = (peer *)data; + CachePeer *p = (CachePeer *)data; ps_state *psstate; StoreEntry *fake; MemObject *mem; @@ -1418,7 +1418,7 @@ peerCountMcastPeersDone(void *data) StoreEntry *fake = psstate->entry; if (cbdataReferenceValid(psstate->callback_data)) { - peer *p = (peer *)psstate->callback_data; + CachePeer *p = (CachePeer *)psstate->callback_data; p->mcast.flags.counting = 0; p->mcast.avg_n_members = Math::doubleAverage(p->mcast.avg_n_members, (double) psstate->ping.n_recv, ++p->mcast.n_times_counted, 10); debugs(15, DBG_IMPORTANT, "Group " << p->host << ": " << psstate->ping.n_recv << @@ -1437,7 +1437,7 @@ peerCountMcastPeersDone(void *data) } static void -peerCountHandleIcpReply(peer * p, peer_t type, AnyP::ProtocolType proto, void *hdrnotused, void *data) +peerCountHandleIcpReply(CachePeer * p, peer_t type, AnyP::ProtocolType proto, void *hdrnotused, void *data) { int rtt_av_factor; @@ -1470,7 +1470,7 @@ neighborDumpNonPeers(StoreEntry * sentry) } void -dump_peer_options(StoreEntry * sentry, peer * p) +dump_peer_options(StoreEntry * sentry, CachePeer * p) { if (p->options.proxy_only) storeAppendPrintf(sentry, " proxy-only"); @@ -1588,9 +1588,9 @@ dump_peer_options(StoreEntry * sentry, peer * p) } static void -dump_peers(StoreEntry * sentry, peer * peers) +dump_peers(StoreEntry * sentry, CachePeer * peers) { - peer *e = NULL; + CachePeer *e = NULL; char ntoabuf[MAX_IPSTRLEN]; domain_ping *d = NULL; icp_opcode op; @@ -1699,7 +1699,7 @@ neighborsHtcpReply(const cache_key * key, htcpReplyData * htcp, const Ip::Addres { StoreEntry *e = Store::Root().get(key); MemObject *mem = NULL; - peer *p; + CachePeer *p; peer_t ntype = PEER_NONE; debugs(15, 6, "neighborsHtcpReply: " << (htcp->hit ? "HIT" : "MISS") << " " << @@ -1764,7 +1764,7 @@ neighborsHtcpReply(const cache_key * key, htcpReplyData * htcp, const Ip::Addres void neighborsHtcpClear(StoreEntry * e, const char *uri, HttpRequest * req, const HttpRequestMethod &method, htcp_clr_reason reason) { - peer *p; + CachePeer *p; char buf[128]; for (p = Config.peers; p; p = p->next) { diff --git a/src/neighbors.h b/src/neighbors.h index 7ef71a6f71..3c47d51065 100644 --- a/src/neighbors.h +++ b/src/neighbors.h @@ -39,13 +39,13 @@ class HttpRequest; class HttpRequestMethod; -class peer; +class CachePeer; class StoreEntry; -extern peer *getFirstPeer(void); -extern peer *getFirstUpParent(HttpRequest *); -extern peer *getNextPeer(peer *); -extern peer *getSingleParent(HttpRequest *); +extern CachePeer *getFirstPeer(void); +extern CachePeer *getFirstUpParent(HttpRequest *); +extern CachePeer *getNextPeer(CachePeer *); +extern CachePeer *getSingleParent(HttpRequest *); extern int neighborsCount(HttpRequest *); extern int neighborsUdpPing(HttpRequest *, StoreEntry *, @@ -61,26 +61,26 @@ extern void neighbors_init(void); #if USE_HTCP extern void neighborsHtcpClear(StoreEntry *, const char *, HttpRequest *, const HttpRequestMethod &, htcp_clr_reason); #endif -extern peer *peerFindByName(const char *); -extern peer *peerFindByNameAndPort(const char *, unsigned short); -extern peer *getDefaultParent(HttpRequest * request); -extern peer *getRoundRobinParent(HttpRequest * request); -extern peer *getWeightedRoundRobinParent(HttpRequest * request); +extern CachePeer *peerFindByName(const char *); +extern CachePeer *peerFindByNameAndPort(const char *, unsigned short); +extern CachePeer *getDefaultParent(HttpRequest * request); +extern CachePeer *getRoundRobinParent(HttpRequest * request); +extern CachePeer *getWeightedRoundRobinParent(HttpRequest * request); extern void peerClearRRStart(void); extern void peerClearRR(void); -extern lookup_t peerDigestLookup(peer * p, HttpRequest * request); -extern peer *neighborsDigestSelect(HttpRequest * request); -extern void peerNoteDigestLookup(HttpRequest * request, peer * p, lookup_t lookup); -extern void peerNoteDigestGone(peer * p); -extern int neighborUp(const peer * e); +extern lookup_t peerDigestLookup(CachePeer * p, HttpRequest * request); +extern CachePeer *neighborsDigestSelect(HttpRequest * request); +extern void peerNoteDigestLookup(HttpRequest * request, CachePeer * p, lookup_t lookup); +extern void peerNoteDigestGone(CachePeer * p); +extern int neighborUp(const CachePeer * e); extern CBDUNL peerDestroy; -extern const char *neighborTypeStr(const peer * e); -extern peer_t neighborType(const peer *, const HttpRequest *); -extern void peerConnectFailed(peer *); -extern void peerConnectSucceded(peer *); -extern void dump_peer_options(StoreEntry *, peer *); -extern int peerHTTPOkay(const peer *, HttpRequest *); +extern const char *neighborTypeStr(const CachePeer * e); +extern peer_t neighborType(const CachePeer *, const HttpRequest *); +extern void peerConnectFailed(CachePeer *); +extern void peerConnectSucceded(CachePeer *); +extern void dump_peer_options(StoreEntry *, CachePeer *); +extern int peerHTTPOkay(const CachePeer *, HttpRequest *); -extern peer *whichPeer(const Ip::Address &from); +extern CachePeer *whichPeer(const Ip::Address &from); #endif /* SQUID_NEIGHBORS_H_ */ diff --git a/src/peer_digest.cc b/src/peer_digest.cc index 95368c4d34..6810276103 100644 --- a/src/peer_digest.cc +++ b/src/peer_digest.cc @@ -90,7 +90,7 @@ static time_t pd_last_req_time = 0; /* last call to Check */ /* initialize peer digest */ static void -peerDigestInit(PeerDigest * pd, peer * p) +peerDigestInit(PeerDigest * pd, CachePeer * p) { assert(pd && p); @@ -137,7 +137,7 @@ PeerDigest::operator delete (void *address) /* allocate new peer digest, call Init, and lock everything */ PeerDigest * -peerDigestCreate(peer * p) +peerDigestCreate(CachePeer * p) { PeerDigest *pd; assert(p); @@ -164,7 +164,7 @@ peerDigestDestroy(PeerDigest * pd) * tell it that the digest is gone. */ if (cbdataReferenceValidDone(peerTmp, &p)) - peerNoteDigestGone((peer *)p); + peerNoteDigestGone((CachePeer *)p); peerDigestClean(pd); @@ -312,7 +312,7 @@ CBDATA_TYPE(DigestFetchState); static void peerDigestRequest(PeerDigest * pd) { - peer *p = pd->peer; + CachePeer *p = pd->peer; StoreEntry *e, *old_e; char *url; const cache_key *key; diff --git a/src/peer_select.cc b/src/peer_select.cc index 0322611c2c..c2df90d8f7 100644 --- a/src/peer_select.cc +++ b/src/peer_select.cc @@ -69,10 +69,10 @@ static void peerSelectFoo(ps_state *); static void peerPingTimeout(void *data); static IRCB peerHandlePingReply; static void peerSelectStateFree(ps_state * psstate); -static void peerIcpParentMiss(peer *, icp_common_t *, ps_state *); +static void peerIcpParentMiss(CachePeer *, icp_common_t *, ps_state *); #if USE_HTCP -static void peerHtcpParentMiss(peer *, htcpReplyData *, ps_state *); -static void peerHandleHtcpReply(peer *, peer_t, htcpReplyData *, void *); +static void peerHtcpParentMiss(CachePeer *, htcpReplyData *, ps_state *); +static void peerHandleHtcpReply(CachePeer *, peer_t, htcpReplyData *, void *); #endif static int peerCheckNetdbDirect(ps_state * psstate); static void peerGetSomeNeighbor(ps_state *); @@ -80,7 +80,7 @@ static void peerGetSomeNeighborReplies(ps_state *); static void peerGetSomeDirect(ps_state *); static void peerGetSomeParent(ps_state *); static void peerGetAllParents(ps_state *); -static void peerAddFwdServer(FwdServer **, peer *, hier_code); +static void peerAddFwdServer(FwdServer **, CachePeer *, hier_code); static void peerSelectPinned(ps_state * ps); static void peerSelectDnsResults(const ipcache_addrs *ia, const DnsLookupDetails &details, void *data); @@ -381,7 +381,7 @@ static int peerCheckNetdbDirect(ps_state * psstate) { #if USE_ICMP - peer *p; + CachePeer *p; int myrtt; int myhops; @@ -506,7 +506,7 @@ peerSelectFoo(ps_state * ps) peerSelectDnsPaths(ps); } -bool peerAllowedToUse(const peer * p, HttpRequest * request); +bool peerAllowedToUse(const CachePeer * p, HttpRequest * request); /** * peerSelectPinned @@ -519,7 +519,7 @@ peerSelectPinned(ps_state * ps) HttpRequest *request = ps->request; if (!request->pinnedConnection()) return; - peer *pear = request->pinnedConnection()->pinnedPeer(); + CachePeer *pear = request->pinnedConnection()->pinnedPeer(); if (Comm::IsConnOpen(request->pinnedConnection()->validatePinnedConnection(request, pear))) { if (pear && peerAllowedToUse(pear, request)) { peerAddFwdServer(&ps->servers, pear, PINNED); @@ -548,7 +548,7 @@ peerGetSomeNeighbor(ps_state * ps) { StoreEntry *entry = ps->entry; HttpRequest *request = ps->request; - peer *p; + CachePeer *p; hier_code code = HIER_NONE; assert(entry->ping_status == PING_NONE); @@ -612,7 +612,7 @@ static void peerGetSomeNeighborReplies(ps_state * ps) { HttpRequest *request = ps->request; - peer *p = NULL; + CachePeer *p = NULL; hier_code code = HIER_NONE; assert(ps->entry->ping_status == PING_WAITING); assert(ps->direct != DIRECT_YES); @@ -663,7 +663,7 @@ peerGetSomeDirect(ps_state * ps) static void peerGetSomeParent(ps_state * ps) { - peer *p; + CachePeer *p; HttpRequest *request = ps->request; hier_code code = HIER_NONE; debugs(44, 3, "peerGetSomeParent: " << RequestMethodStr(request->method) << " " << request->GetHost()); @@ -700,7 +700,7 @@ peerGetSomeParent(ps_state * ps) static void peerGetAllParents(ps_state * ps) { - peer *p; + CachePeer *p; HttpRequest *request = ps->request; /* Add all alive parents */ @@ -760,7 +760,7 @@ peerSelectInit(void) } static void -peerIcpParentMiss(peer * p, icp_common_t * header, ps_state * ps) +peerIcpParentMiss(CachePeer * p, icp_common_t * header, ps_state * ps) { int rtt; @@ -801,7 +801,7 @@ peerIcpParentMiss(peer * p, icp_common_t * header, ps_state * ps) } static void -peerHandleIcpReply(peer * p, peer_t type, icp_common_t * header, void *data) +peerHandleIcpReply(CachePeer * p, peer_t type, icp_common_t * header, void *data) { ps_state *psstate = (ps_state *)data; icp_opcode op = header->getOpCode(); @@ -835,7 +835,7 @@ peerHandleIcpReply(peer * p, peer_t type, icp_common_t * header, void *data) #if USE_HTCP static void -peerHandleHtcpReply(peer * p, peer_t type, htcpReplyData * htcp, void *data) +peerHandleHtcpReply(CachePeer * p, peer_t type, htcpReplyData * htcp, void *data) { ps_state *psstate = (ps_state *)data; debugs(44, 3, "peerHandleHtcpReply: " << @@ -860,7 +860,7 @@ peerHandleHtcpReply(peer * p, peer_t type, htcpReplyData * htcp, void *data) } static void -peerHtcpParentMiss(peer * p, htcpReplyData * htcp, ps_state * ps) +peerHtcpParentMiss(CachePeer * p, htcpReplyData * htcp, ps_state * ps) { int rtt; @@ -901,7 +901,7 @@ peerHtcpParentMiss(peer * p, htcpReplyData * htcp, ps_state * ps) #endif static void -peerHandlePingReply(peer * p, peer_t type, AnyP::ProtocolType proto, void *pingdata, void *data) +peerHandlePingReply(CachePeer * p, peer_t type, AnyP::ProtocolType proto, void *pingdata, void *data) { if (proto == AnyP::PROTO_ICP) peerHandleIcpReply(p, type, (icp_common_t *)pingdata, data); @@ -918,7 +918,7 @@ peerHandlePingReply(peer * p, peer_t type, AnyP::ProtocolType proto, void *pingd } static void -peerAddFwdServer(FwdServer ** FSVR, peer * p, hier_code code) +peerAddFwdServer(FwdServer ** FSVR, CachePeer * p, hier_code code) { FwdServer *fs = (FwdServer *)memAllocate(MEM_FWD_SERVER); debugs(44, 5, "peerAddFwdServer: adding " << diff --git a/src/peer_sourcehash.cc b/src/peer_sourcehash.cc index 0ea8d8836a..86a9b0b108 100644 --- a/src/peer_sourcehash.cc +++ b/src/peer_sourcehash.cc @@ -46,15 +46,15 @@ #define ROTATE_LEFT(x, n) (((x) << (n)) | ((x) >> (32-(n)))) static int n_sourcehash_peers = 0; -static peer **sourcehash_peers = NULL; +static CachePeer **sourcehash_peers = NULL; static OBJH peerSourceHashCachemgr; static void peerSourceHashRegisterWithCacheManager(void); static int peerSortWeight(const void *a, const void *b) { - const peer *const *p1 = (const peer *const *)a; - const peer *const *p2 = (const peer *const *)b; + const CachePeer *const *p1 = (const CachePeer *const *)a; + const CachePeer *const *p2 = (const CachePeer *const *)b; return (*p1)->weight - (*p2)->weight; } @@ -65,8 +65,8 @@ peerSourceHashInit(void) int K; int k; double P_last, X_last, Xn; - peer *p; - peer **P; + CachePeer *p; + CachePeer **P; char *t; /* Clean up */ @@ -97,7 +97,7 @@ peerSourceHashInit(void) if (n_sourcehash_peers == 0) return; - sourcehash_peers = (peer **)xcalloc(n_sourcehash_peers, sizeof(*sourcehash_peers)); + sourcehash_peers = (CachePeer **)xcalloc(n_sourcehash_peers, sizeof(*sourcehash_peers)); /* Build a list of the found peers and calculate hashes and load factors */ for (P = sourcehash_peers, p = Config.peers; p; p = p->next) { @@ -165,13 +165,13 @@ peerSourceHashRegisterWithCacheManager(void) peerSourceHashCachemgr, 0, 1); } -peer * +CachePeer * peerSourceHashSelectParent(HttpRequest * request) { int k; const char *c; - peer *p = NULL; - peer *tp; + CachePeer *p = NULL; + CachePeer *tp; unsigned int user_hash = 0; unsigned int combined_hash; double score; @@ -190,7 +190,7 @@ peerSourceHashSelectParent(HttpRequest * request) for (c = key; *c != 0; ++c) user_hash += ROTATE_LEFT(user_hash, 19) + *c; - /* select peer */ + /* select CachePeer */ for (k = 0; k < n_sourcehash_peers; ++k) { tp = sourcehash_peers[k]; combined_hash = (user_hash ^ tp->sourcehash.hash); @@ -215,7 +215,7 @@ peerSourceHashSelectParent(HttpRequest * request) static void peerSourceHashCachemgr(StoreEntry * sentry) { - peer *p; + CachePeer *p; int sumfetches = 0; storeAppendPrintf(sentry, "%24s %10s %10s %10s %10s\n", "Hostname", diff --git a/src/peer_sourcehash.h b/src/peer_sourcehash.h index 10685c3810..efd9eafcb4 100644 --- a/src/peer_sourcehash.h +++ b/src/peer_sourcehash.h @@ -34,10 +34,10 @@ #ifndef SQUID_PEER_SOURCEHASH_H_ #define SQUID_PEER_SOURCEHASH_H_ -class peer; +class CachePeer; class HttpRequest; extern void peerSourceHashInit(void); -extern peer * peerSourceHashSelectParent(HttpRequest * request); +extern CachePeer * peerSourceHashSelectParent(HttpRequest * request); #endif /* SQUID_PEER_SOURCEHASH_H_ */ diff --git a/src/peer_userhash.cc b/src/peer_userhash.cc index d9c84e92bd..ac3fd05ca9 100644 --- a/src/peer_userhash.cc +++ b/src/peer_userhash.cc @@ -51,15 +51,15 @@ #define ROTATE_LEFT(x, n) (((x) << (n)) | ((x) >> (32-(n)))) static int n_userhash_peers = 0; -static peer **userhash_peers = NULL; +static CachePeer **userhash_peers = NULL; static OBJH peerUserHashCachemgr; static void peerUserHashRegisterWithCacheManager(void); static int peerSortWeight(const void *a, const void *b) { - const peer *const *p1 = (const peer *const *)a; - const peer *const *p2 = (const peer *const *)b; + const CachePeer *const *p1 = (const CachePeer *const *)a; + const CachePeer *const *p2 = (const CachePeer *const *)b; return (*p1)->weight - (*p2)->weight; } @@ -70,8 +70,8 @@ peerUserHashInit(void) int K; int k; double P_last, X_last, Xn; - peer *p; - peer **P; + CachePeer *p; + CachePeer **P; char *t; /* Clean up */ @@ -102,7 +102,7 @@ peerUserHashInit(void) if (n_userhash_peers == 0) return; - userhash_peers = (peer **)xcalloc(n_userhash_peers, sizeof(*userhash_peers)); + userhash_peers = (CachePeer **)xcalloc(n_userhash_peers, sizeof(*userhash_peers)); /* Build a list of the found peers and calculate hashes and load factors */ for (P = userhash_peers, p = Config.peers; p; p = p->next) { @@ -170,13 +170,13 @@ peerUserHashRegisterWithCacheManager(void) 0, 1); } -peer * +CachePeer * peerUserHashSelectParent(HttpRequest * request) { int k; const char *c; - peer *p = NULL; - peer *tp; + CachePeer *p = NULL; + CachePeer *tp; unsigned int user_hash = 0; unsigned int combined_hash; double score; @@ -198,7 +198,7 @@ peerUserHashSelectParent(HttpRequest * request) for (c = key; *c != 0; ++c) user_hash += ROTATE_LEFT(user_hash, 19) + *c; - /* select peer */ + /* select CachePeer */ for (k = 0; k < n_userhash_peers; ++k) { tp = userhash_peers[k]; combined_hash = (user_hash ^ tp->userhash.hash); @@ -223,7 +223,7 @@ peerUserHashSelectParent(HttpRequest * request) static void peerUserHashCachemgr(StoreEntry * sentry) { - peer *p; + CachePeer *p; int sumfetches = 0; storeAppendPrintf(sentry, "%24s %10s %10s %10s %10s\n", "Hostname", diff --git a/src/peer_userhash.h b/src/peer_userhash.h index b1dc6ccc33..35aa14b758 100644 --- a/src/peer_userhash.h +++ b/src/peer_userhash.h @@ -34,10 +34,10 @@ #ifndef SQUID_PEER_USERHASH_H_ #define SQUID_PEER_USERHASH_H_ -class peer; +class CachePeer; class HttpRequest; extern void peerUserHashInit(void); -extern peer * peerUserHashSelectParent(HttpRequest * request); +extern CachePeer * peerUserHashSelectParent(HttpRequest * request); #endif /* SQUID_PEER_USERHASH_H_ */ diff --git a/src/snmp_agent.cc b/src/snmp_agent.cc index 4f0a103328..45d9c1fe59 100644 --- a/src/snmp_agent.cc +++ b/src/snmp_agent.cc @@ -208,7 +208,7 @@ snmp_meshPtblFn(variable_list * Var, snint * ErrP) Ip::Address laddr; char *cp = NULL; - peer *p = NULL; + CachePeer *p = NULL; int cnt = 0; debugs(49, 5, "snmp_meshPtblFn: peer " << Var->name[LEN_SQ_MESH + 3] << " requested!"); *ErrP = SNMP_ERR_NOERROR; diff --git a/src/snmp_core.cc b/src/snmp_core.cc index a26e80edaf..ef10fdec06 100644 --- a/src/snmp_core.cc +++ b/src/snmp_core.cc @@ -748,7 +748,7 @@ static oid * peer_Inst(oid * name, snint * len, mib_tree_entry * current, oid_ParseFn ** Fn) { oid *instance = NULL; - peer *peers = Config.peers; + CachePeer *peers = Config.peers; if (peers == NULL) { debugs(49, 6, "snmp peer_Inst: No Peers."); diff --git a/src/stat.cc b/src/stat.cc index cbb47a3b2d..e1daab5e42 100644 --- a/src/stat.cc +++ b/src/stat.cc @@ -1811,7 +1811,7 @@ statPeerSelect(StoreEntry * sentry) { #if USE_CACHE_DIGESTS StatCounters *f = &statCounter; - peer *peer; + CachePeer *peer; const int tot_used = f->cd.times_used + f->icp.times_used; /* totals */ diff --git a/src/structs.h b/src/structs.h index b4be3908a5..c02b2ed82e 100644 --- a/src/structs.h +++ b/src/structs.h @@ -218,7 +218,8 @@ public: class PeerDigest; -struct peer { +class CachePeer { +public: u_int index; char *name; char *host; @@ -331,7 +332,7 @@ struct peer { Ip::Address addresses[10]; int n_addresses; int rr_count; - peer *next; + CachePeer *next; int testing_now; struct { diff --git a/src/tests/stub_libcomm.cc b/src/tests/stub_libcomm.cc index b2632fc0e9..a52cd8c776 100644 --- a/src/tests/stub_libcomm.cc +++ b/src/tests/stub_libcomm.cc @@ -17,8 +17,8 @@ Comm::Connection::Connection() STUB Comm::Connection::~Connection() STUB Comm::ConnectionPointer Comm::Connection::copyDetails() const STUB_RETVAL(NULL) void Comm::Connection::close() STUB -peer * Comm::Connection::getPeer() const STUB_RETVAL(NULL) -void Comm::Connection::setPeer(peer * p) STUB +CachePeer * Comm::Connection::getPeer() const STUB_RETVAL(NULL) +void Comm::Connection::setPeer(CachePeer * p) STUB #include "comm/ConnOpener.h" CBDATA_NAMESPACED_CLASS_INIT(Comm, ConnOpener); diff --git a/src/tests/stub_libicmp.cc b/src/tests/stub_libicmp.cc index d5d539a174..974646889b 100644 --- a/src/tests/stub_libicmp.cc +++ b/src/tests/stub_libicmp.cc @@ -22,10 +22,10 @@ void netdbDump(StoreEntry *) STUB void netdbFreeMemory(void) STUB int netdbHostHops(const char *host) STUB_RETVAL(-1) int netdbHostRtt(const char *host) STUB_RETVAL(-1) -void netdbUpdatePeer(HttpRequest *, peer * e, int rtt, int hops) STUB +void netdbUpdatePeer(HttpRequest *, CachePeer * e, int rtt, int hops) STUB void netdbDeleteAddrNetwork(Ip::Address &addr) STUB void netdbBinaryExchange(StoreEntry *) STUB void netdbExchangeStart(void *) STUB -void netdbExchangeUpdatePeer(Ip::Address &, peer *, double, double) STUB -peer *netdbClosestParent(HttpRequest *) STUB_RETVAL(NULL) +void netdbExchangeUpdatePeer(Ip::Address &, CachePeer *, double, double) STUB +CachePeer *netdbClosestParent(HttpRequest *) STUB_RETVAL(NULL) void netdbHostData(const char *host, int *samp, int *rtt, int *hops) STUB diff --git a/src/typedefs.h b/src/typedefs.h index fd2d21b438..b3846cbd0f 100644 --- a/src/typedefs.h +++ b/src/typedefs.h @@ -80,7 +80,8 @@ typedef void FQDNH(const char *, const DnsLookupDetails &details, void *); typedef void IDCB(const char *ident, void *data); #include "anyp/ProtocolType.h" -typedef void IRCB(struct peer *, peer_t, AnyP::ProtocolType, void *, void *data); +class CachePeer; +typedef void IRCB(CachePeer *, peer_t, AnyP::ProtocolType, void *, void *data); typedef void RH(void *data, char *); /* in wordlist.h */