From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Wed, 15 Jan 2025 06:54:52 +0000 (+0300)
Subject: wifi: mac80211: fix memory leak in ieee80211_mgd_assoc_ml_reconf()
X-Git-Tag: v6.14-rc1~162^2~20^2~7
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a4058dc1e7b0051b2baf604fd9db8f1f7d529600;p=thirdparty%2Fkernel%2Flinux.git

wifi: mac80211: fix memory leak in ieee80211_mgd_assoc_ml_reconf()

Free the "data" allocation before returning on this error path.

Fixes: 36e05b0b8390 ("wifi: mac80211: Support dynamic link addition and removal")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/7ad826a7-7651-48e7-9589-7d2dc17417c2@stanley.mountain
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---

diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index 0d3f64eb573e3..f8d52b3b0d0e4 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -10273,8 +10273,10 @@ int ieee80211_mgd_assoc_ml_reconf(struct ieee80211_sub_if_data *sdata,
 	 * on which the request was received.
 	 */
 	skb = ieee80211_build_ml_reconf_req(sdata, data, rem_links);
-	if (!skb)
-		return -ENOMEM;
+	if (!skb) {
+		err = -ENOMEM;
+		goto err_free;
+	}
 
 	if (rem_links) {
 		u16 new_dormant_links = sdata->vif.dormant_links & ~rem_links;