From: Stefan Berger <stefanb@linux.vnet.ibm.com>
Date: Thu, 17 Apr 2014 10:30:08 +0000 (-0400)
Subject: qemu: Unlock the NWFilter update lock by leaving via the cleanup label
X-Git-Tag: v1.2.4-rc1~91
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a4209f53795290ff9f2173092800eb3f767fff3e;p=thirdparty%2Flibvirt.git

qemu: Unlock the NWFilter update lock by leaving via the cleanup label

Fix a locking problem by leaving the function via the cleanup label.

Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 454e39fb11..e58fa3fe58 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -6140,7 +6140,7 @@ qemuDomainCreateWithFlags(virDomainPtr dom, unsigned int flags)
     virNWFilterReadLockFilterUpdates();
 
     if (!(vm = qemuDomObjFromDomain(dom)))
-        return -1;
+        goto cleanup;
 
     if (virDomainCreateWithFlagsEnsureACL(dom->conn, vm->def) < 0)
         goto cleanup;