From: Brett Cannon <brett@python.org>
Date: Fri, 5 Aug 2011 04:34:52 +0000 (-0700)
Subject: Explicitly close a file to stop raising a ResourceWarning.
X-Git-Tag: v3.3.0a1~1750
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a4265546f9d457ff61e7e4d3fb6d6b3cc54a09d2;p=thirdparty%2FPython%2Fcpython.git

Explicitly close a file to stop raising a ResourceWarning.
---

diff --git a/Lib/test/test_sysconfig.py b/Lib/test/test_sysconfig.py
index 96f75f282d09..241af8fc0d9d 100644
--- a/Lib/test/test_sysconfig.py
+++ b/Lib/test/test_sysconfig.py
@@ -306,19 +306,20 @@ class TestSysConfig(unittest.TestCase):
         env = os.environ.copy()
         env['MACOSX_DEPLOYMENT_TARGET'] = '10.1'
 
-        p = subprocess.Popen([
-                sys.executable, '-c',
-                'import sysconfig; print(sysconfig.get_platform())',
-            ],
-            stdout=subprocess.PIPE,
-            stderr=open('/dev/null'),
-            env=env)
-        test_platform = p.communicate()[0].strip()
-        test_platform = test_platform.decode('utf-8')
-        status = p.wait()
+        with open('/dev/null') as dev_null:
+            p = subprocess.Popen([
+                    sys.executable, '-c',
+                    'import sysconfig; print(sysconfig.get_platform())',
+                ],
+                stdout=subprocess.PIPE,
+                stderr=dev_null,
+                env=env)
+            test_platform = p.communicate()[0].strip()
+            test_platform = test_platform.decode('utf-8')
+            status = p.wait()
 
-        self.assertEqual(status, 0)
-        self.assertEqual(my_platform, test_platform)
+            self.assertEqual(status, 0)
+            self.assertEqual(my_platform, test_platform)
 
 
 class MakefileTests(unittest.TestCase):