From: Fred Morcos <fred.morcos@open-xchange.com>
Date: Wed, 15 Feb 2023 15:11:35 +0000 (+0100)
Subject: Cleanup CommunicatorClass
X-Git-Tag: dnsdist-1.8.0-rc1~3^2~10
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a445dac8c42d7f282ba4f9e9f7252a6406ee6ea5;p=thirdparty%2Fpdns.git

Cleanup CommunicatorClass
---

diff --git a/pdns/communicator.hh b/pdns/communicator.hh
index b4e90f3bcb..fe4ffe4bdb 100644
--- a/pdns/communicator.hh
+++ b/pdns/communicator.hh
@@ -179,8 +179,7 @@ private:
   LockGuarded<map<pair<DNSName,string>,time_t>> d_holes;
 
   void suck(const DNSName &domain, const ComboAddress& remote, bool force=false);
-  void ixfrSuck(const DNSName &domain, const TSIGTriplet& tt, const ComboAddress& laddr, const ComboAddress& remote, std::unique_ptr<AuthLua4>& pdl,
-                ZoneStatus& zs, vector<DNSRecord>* axfr);
+  void ixfrSuck(const DNSName& domain, const TSIGTriplet& tt, const ComboAddress& laddr, const ComboAddress& remote, ZoneStatus& zs, vector<DNSRecord>* axfr);
 
   void slaveRefresh(PacketHandler *P);
   void masterUpdateCheck(PacketHandler *P);
diff --git a/pdns/slavecommunicator.cc b/pdns/slavecommunicator.cc
index 62d110929b..a60d12dfea 100644
--- a/pdns/slavecommunicator.cc
+++ b/pdns/slavecommunicator.cc
@@ -421,7 +421,7 @@ static bool catalogProcess(const DomainInfo& di, vector<DNSResourceRecord>& rrs,
   return catalogDiff(di, fromXFR, fromDB, logPrefix);
 }
 
-void CommunicatorClass::ixfrSuck(const DNSName& domain, const TSIGTriplet& tt, const ComboAddress& laddr, const ComboAddress& remote, unique_ptr<AuthLua4>& /* pdl */, ZoneStatus& zs, vector<DNSRecord>* axfr)
+void CommunicatorClass::ixfrSuck(const DNSName& domain, const TSIGTriplet& tt, const ComboAddress& laddr, const ComboAddress& remote, ZoneStatus& zs, vector<DNSRecord>* axfr)
 {
   string logPrefix="IXFR-in zone '"+domain.toLogString()+"', primary '"+remote.toString()+"', ";
 
@@ -754,7 +754,7 @@ void CommunicatorClass::suck(const DNSName &domain, const ComboAddress& remote,
         logPrefix = "I" + logPrefix; // XFR -> IXFR
         vector<DNSRecord> axfr;
         g_log<<Logger::Notice<<logPrefix<<"starting IXFR"<<endl;
-        ixfrSuck(domain, tt, laddr, remote, pdl, zs, &axfr);
+        ixfrSuck(domain, tt, laddr, remote, zs, &axfr);
         if(!axfr.empty()) {
           g_log<<Logger::Notice<<logPrefix<<"IXFR turned into an AXFR"<<endl;
           logPrefix[0]='A'; // IXFR -> AXFR