From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Wed, 1 Nov 2017 19:41:18 +0000 (+0200)
Subject: login-common: Remove unnecessary client_ref/unref from STARTTLS handling
X-Git-Tag: 2.3.0.rc1~597
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a44e36b9c7fc0ad7dca26793c8216b13fb8632dd;p=thirdparty%2Fdovecot%2Fcore.git

login-common: Remove unnecessary client_ref/unref from STARTTLS handling

There used to be code between them that could have destroyed the connection,
but that was removed long time ago.
---

diff --git a/src/login-common/client-common.c b/src/login-common/client-common.c
index 5c65aa5cd6..9d9c230c12 100644
--- a/src/login-common/client-common.c
+++ b/src/login-common/client-common.c
@@ -409,10 +409,6 @@ static void client_start_tls(struct client *client)
 {
 	int fd_ssl;
 
-	client_ref(client);
-	if (!client_unref(&client) || client->destroyed)
-		return;
-
 	fd_ssl = ssl_proxy_alloc(client->fd, &client->ip, client->pool,
 				 client->set, client->ssl_set,
 				 &client->ssl_proxy);