From: Peter Geoghegan <pg@bowt.ie>
Date: Mon, 3 Aug 2020 20:04:42 +0000 (-0700)
Subject: Add nbtree page deletion assertion.
X-Git-Tag: REL_14_BETA1~1874
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a451b7d44249b8655db8d40476ace9f84d76ab88;p=thirdparty%2Fpostgresql.git

Add nbtree page deletion assertion.

Add a documenting assertion that's similar to the nearby assertion added
by commit cd8c73a3.  This conveys that the entire call to _bt_pagedel()
does no work if it isn't possible to get a descent stack for the initial
scanblkno page.
---

diff --git a/src/backend/access/nbtree/nbtpage.c b/src/backend/access/nbtree/nbtpage.c
index 70bac0052fc..53dff326808 100644
--- a/src/backend/access/nbtree/nbtpage.c
+++ b/src/backend/access/nbtree/nbtpage.c
@@ -1697,6 +1697,7 @@ _bt_pagedel(Relation rel, Buffer leafbuf, TransactionId *oldestBtpoXact)
 				if (_bt_leftsib_splitflag(rel, leftsib, leafblkno))
 				{
 					ReleaseBuffer(leafbuf);
+					Assert(ndeleted == 0);
 					return ndeleted;
 				}