From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Fri, 18 Jul 2008 04:20:24 +0000 (+0000)
Subject: Suppress compiler warning, and not incidentally make the code more
X-Git-Tag: REL8_4_BETA1~1148
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a4775a80fd444162ff878d2e945c8af7ba37eb89;p=thirdparty%2Fpostgresql.git

Suppress compiler warning, and not incidentally make the code more
robust.  The previous coding was quite risky because it was testing
conditions different from 'is the array really allocated?'.
---

diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c
index 0a0819cc029..137ea6c2d44 100644
--- a/src/bin/psql/describe.c
+++ b/src/bin/psql/describe.c
@@ -8,7 +8,7 @@
  *
  * Copyright (c) 2000-2008, PostgreSQL Global Development Group
  *
- * $PostgreSQL: pgsql/src/bin/psql/describe.c,v 1.183 2008/07/18 03:32:52 tgl Exp $
+ * $PostgreSQL: pgsql/src/bin/psql/describe.c,v 1.184 2008/07/18 04:20:24 tgl Exp $
  */
 #include "postgres_fe.h"
 
@@ -1591,14 +1591,14 @@ error_return:
 	termPQExpBuffer(&title);
 	termPQExpBuffer(&tmpbuf);
 	
-	if (tableinfo.relkind == 'S')
+	if (seq_values)
 	{
 		for (ptr = seq_values; *ptr; ptr++)
 			free(*ptr);
 		free(seq_values);
 	}
     
-	if (show_modifiers)
+	if (modifiers)
 	{
 		for (ptr = modifiers; *ptr; ptr++)
 			free(*ptr);