From: Pedro Alves Date: Sat, 21 Feb 2015 12:03:23 +0000 (+0000) Subject: gdb.threads/multi-create-ns-info-thr.exp and native-extended-remote board X-Git-Tag: users/hjl/linux/release/2.25.51.0.2~2^2~39^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a47cd6e95a6eeaae01c96b89880330c4c1db0c4b;p=thirdparty%2Fbinutils-gdb.git gdb.threads/multi-create-ns-info-thr.exp and native-extended-remote board The buildbot shows that the new gdb.threads/multi-create-ns-info-thr.exp test is timing out when tested with --target=native-extended-remote. The reason is: No breakpoints or watchpoints. (gdb) break main Breakpoint 1 at 0x10000b00: file ../../../binutils-gdb/gdb/testsuite/gdb.threads/multi-create.c, line 72. (gdb) run Starting program: /home/gdb-buildbot/fedora-21-ppc64be-1/fedora-ppc64be-native-extended-gdbserver/build/gdb/testsuite/outputs/gdb.threads/multi-create-ns-info-thr/multi-cre ate-ns-info-thr Process /home/gdb-buildbot/fedora-21-ppc64be-1/fedora-ppc64be-native-extended-gdbserver/build/gdb/testsuite/outputs/gdb.threads/multi-create-ns-info-thr/multi-create-ns-inf o-thr created; pid = 16266 Unexpected vCont reply in non-stop mode: T0501:00003fffffffd190;40:00000080560fe290;thread:p3f8a.3f8a;core:0; ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ (gdb) break multi-create.c:45 Breakpoint 2 at 0x10000994: file ../../../binutils-gdb/gdb/testsuite/gdb.threads/multi-create.c, line 45. (gdb) commands Type commands for breakpoint(s) 2, one per line. Non-stop tests don't really work with the --target_board=native-extended-remote board, because tests toggle non-stop on after GDB is already connected to gdbserver, while Currently, non-stop must be enabled before connecting. This adjusts the test to bail if running to main fails, like all other non-stop tests. Note non-stop tests do work with --target_board=native-gdbserver. gdb/testsuite/ChangeLog: 2015-02-21 Pedro Alves * gdb.threads/multi-create-ns-info-thr.exp: Return early if runto_main fails. --- diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 1e1ee536745..c64aeda9372 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2015-02-21 Pedro Alves + + * gdb.threads/multi-create-ns-info-thr.exp: Return early if + runto_main fails. + 2015-02-20 Pedro Alves * gdb.base/solib-corrupted.exp: Expect "stap" as first column of diff --git a/gdb/testsuite/gdb.threads/multi-create-ns-info-thr.exp b/gdb/testsuite/gdb.threads/multi-create-ns-info-thr.exp index 906532ea226..51e537ec3e3 100644 --- a/gdb/testsuite/gdb.threads/multi-create-ns-info-thr.exp +++ b/gdb/testsuite/gdb.threads/multi-create-ns-info-thr.exp @@ -25,7 +25,9 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug pthreads} gdb_test_no_output "set pagination off" gdb_test_no_output "set non-stop on" -runto_main +if ![runto_main] { + return -1 +} # Create a breakpoint that does "info threads" when hit, which will be # just while other threads are being created or exiting.