From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Tue, 24 Jun 2025 07:56:22 +0000 (+0200)
Subject: Use std::copy instead of memcpy
X-Git-Tag: rec-5.3.0-alpha1^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a481b0cefb756b58667eff6bd89e3a729e39866c;p=thirdparty%2Fpdns.git

Use std::copy instead of memcpy

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
---

diff --git a/pdns/protozero-trace.hh b/pdns/protozero-trace.hh
index aa3b6d6d79..12fc115e8f 100644
--- a/pdns/protozero-trace.hh
+++ b/pdns/protozero-trace.hh
@@ -281,7 +281,8 @@ inline TraceID decodeTraceID(protozero::pbf_reader& reader)
 {
   TraceID bytes;
   auto [data, len] = reader.get_data();
-  memcpy(bytes.data(), data, std::min(bytes.size(), static_cast<size_t>(len)));
+  len = std::min(bytes.size(), static_cast<size_t>(len));
+  std::copy(data, data + len, bytes.begin());
   return bytes;
 }
 
@@ -294,7 +295,8 @@ inline SpanID decodeSpanID(protozero::pbf_reader& reader)
 {
   SpanID bytes;
   auto [data, len] = reader.get_data();
-  memcpy(bytes.data(), data, std::min(bytes.size(), static_cast<size_t>(len)));
+  len = std::min(bytes.size(), static_cast<size_t>(len));
+  std::copy(data, data + len, bytes.begin());
   return bytes;
 }