From: Francesco Chemolli <5175948+kinkie@users.noreply.github.com>
Date: Wed, 1 May 2024 15:03:40 +0000 (+0000)
Subject: Optimization: Fs::Ufs::RebuildState constructor copied dir ptr (#1802)
X-Git-Tag: SQUID_7_0_1~131
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a499d8c81c2942e6ba780e5711a43af65455a98b;p=thirdparty%2Fsquid.git

Optimization: Fs::Ufs::RebuildState constructor copied dir ptr (#1802)

Detected by Coverity. CID 1529599: Unnecessary object copies can affect
performance (COPY_INSTEAD_OF_MOVE).
---

diff --git a/src/fs/ufs/RebuildState.cc b/src/fs/ufs/RebuildState.cc
index 3551d53a58..2f97dd0ae0 100644
--- a/src/fs/ufs/RebuildState.cc
+++ b/src/fs/ufs/RebuildState.cc
@@ -29,7 +29,7 @@
 
 CBDATA_NAMESPACED_CLASS_INIT(Fs::Ufs,RebuildState);
 
-Fs::Ufs::RebuildState::RebuildState(RefCount<UFSSwapDir> aSwapDir) :
+Fs::Ufs::RebuildState::RebuildState(const RefCount<UFSSwapDir> &aSwapDir) :
     sd(aSwapDir),
     n_read(0),
     LogParser(nullptr),
diff --git a/src/fs/ufs/RebuildState.h b/src/fs/ufs/RebuildState.h
index 73226bcf82..9f2ee9df84 100644
--- a/src/fs/ufs/RebuildState.h
+++ b/src/fs/ufs/RebuildState.h
@@ -28,7 +28,7 @@ class RebuildState
 public:
     static EVH RebuildStep;
 
-    RebuildState(RefCount<UFSSwapDir> sd);
+    RebuildState(const RefCount<UFSSwapDir> &sd);
     virtual ~RebuildState();
 
     virtual bool error() const;