From: Damien Miller <djm@mindrot.org>
Date: Fri, 31 Mar 2023 03:17:22 +0000 (+1100)
Subject: don't call connect() on negative socket
X-Git-Tag: V_9_4_P1~107
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a4c1c2513e36f111eeaa1322c510067930e5e51e;p=thirdparty%2Fopenssh-portable.git

don't call connect() on negative socket

Coverity CID 405037
---

diff --git a/channels.c b/channels.c
index d9f59f466..ffaf89720 100644
--- a/channels.c
+++ b/channels.c
@@ -5045,8 +5045,10 @@ connect_local_xsocket_path(const char *pathname)
 	struct sockaddr_un addr;
 
 	sock = socket(AF_UNIX, SOCK_STREAM, 0);
-	if (sock == -1)
+	if (sock == -1) {
 		error("socket: %.100s", strerror(errno));
+		return -1;
+	}
 	memset(&addr, 0, sizeof(addr));
 	addr.sun_family = AF_UNIX;
 	strlcpy(addr.sun_path, pathname, sizeof addr.sun_path);