From: Aditya Garg Date: Sun, 9 Feb 2025 07:27:52 +0000 (+0000) Subject: HID: hid-appletb-bl: use appletb_bl_brightness_map instead of magic numbers to set... X-Git-Tag: v6.15-rc1~171^2~13^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a4fa2e6bfe6be8f8b4cc4cf9bf75a26b7da7c1b5;p=thirdparty%2Fkernel%2Flinux.git HID: hid-appletb-bl: use appletb_bl_brightness_map instead of magic numbers to set default brightness This commit makes use of appletb_bl_brightness_map instead of using if statements and magic numbers to set default brightness, and thus simplifies the code. Signed-off-by: Aditya Garg Signed-off-by: Jiri Kosina --- diff --git a/drivers/hid/hid-appletb-bl.c b/drivers/hid/hid-appletb-bl.c index 819157686e59d..1a3dcd44bf1ab 100644 --- a/drivers/hid/hid-appletb-bl.c +++ b/drivers/hid/hid-appletb-bl.c @@ -141,12 +141,8 @@ static int appletb_bl_probe(struct hid_device *hdev, const struct hid_device_id bl->aux1_field = aux1_field; bl->brightness_field = brightness_field; - if (appletb_bl_def_brightness == 0) - ret = appletb_bl_set_brightness(bl, APPLETB_BL_OFF); - else if (appletb_bl_def_brightness == 1) - ret = appletb_bl_set_brightness(bl, APPLETB_BL_DIM); - else - ret = appletb_bl_set_brightness(bl, APPLETB_BL_ON); + ret = appletb_bl_set_brightness(bl, + appletb_bl_brightness_map[(appletb_bl_def_brightness > 2) ? 2 : appletb_bl_def_brightness]); if (ret) { dev_err_probe(dev, ret, "Failed to set touch bar brightness to off\n");