From: Qianfeng Rong Date: Wed, 3 Sep 2025 12:34:03 +0000 (+0800) Subject: net: dsa: dsa_loop: use int type to store negative error codes X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a50e7864ca44f519935cdb04796c714eb9d6670c;p=thirdparty%2Fkernel%2Fstable.git net: dsa: dsa_loop: use int type to store negative error codes Change the 'ret' variable in dsa_loop_init() from unsigned int to int, as it needs to store either negative error codes or zero returned by mdio_driver_register(). Storing the negative error codes in unsigned type, doesn't cause an issue at runtime but can be confusing. Additionally, assigning negative error codes to unsigned type may trigger a GCC warning when the -Wsign-conversion flag is enabled. No effect on runtime. Signed-off-by: Qianfeng Rong Reviewed-by: Vladimir Oltean Link: https://patch.msgid.link/20250903123404.395946-1-rongqianfeng@vivo.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/dsa/dsa_loop.c b/drivers/net/dsa/dsa_loop.c index ad907287a853a..8112515d545ea 100644 --- a/drivers/net/dsa/dsa_loop.c +++ b/drivers/net/dsa/dsa_loop.c @@ -399,7 +399,8 @@ static int __init dsa_loop_init(void) .speed = SPEED_100, .duplex = DUPLEX_FULL, }; - unsigned int i, ret; + unsigned int i; + int ret; for (i = 0; i < NUM_FIXED_PHYS; i++) phydevs[i] = fixed_phy_register(&status, NULL);