From: Claudiu Beznea Date: Wed, 21 May 2025 14:25:41 +0000 (+0300) Subject: genirq/irqdesc: Remove double locking in hwirq_show() X-Git-Tag: v6.16-rc1~189^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a510bb87da72aa8d1504b0e4b343cfe013ee8a89;p=thirdparty%2Flinux.git genirq/irqdesc: Remove double locking in hwirq_show() &desc->lock is acquired on 2 consecutive lines in hwirq_show(). This leads obviously to a deadlock. Drop the raw_spin_lock_irq() and keep guard(). Fixes: 5d964a9f7cd8 ("genirq/irqdesc: Switch to lock guards") Signed-off-by: Claudiu Beznea Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/all/20250521142541.3832130-1-claudiu.beznea.uj@bp.renesas.com --- diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c index 6d006a68ff859..b64c57b44c203 100644 --- a/kernel/irq/irqdesc.c +++ b/kernel/irq/irqdesc.c @@ -281,7 +281,6 @@ static ssize_t hwirq_show(struct kobject *kobj, struct kobj_attribute *attr, cha struct irq_desc *desc = container_of(kobj, struct irq_desc, kobj); guard(raw_spinlock_irq)(&desc->lock); - raw_spin_lock_irq(&desc->lock); if (desc->irq_data.domain) return sysfs_emit(buf, "%lu\n", desc->irq_data.hwirq); return 0;