From: Thomas Haller Date: Thu, 7 Sep 2023 22:07:20 +0000 (+0200) Subject: tests/shell: print "kernel is tainted" separate from test result X-Git-Tag: v1.0.9~118 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a529b3dcda72a8b60eb2ccc9143faf284b01e49c;p=thirdparty%2Fnftables.git tests/shell: print "kernel is tainted" separate from test result Once the kernel is tainted, it stays until reboot. It would not be useful to fail the entire test run based on that (and we don't do that). But then, it seems odd to print this in the same style as the test results, because a [FAILED] of a test counts as an overall failure. Instead, print this warning in a different style. Previously: $ ./tests/shell/run-tests.sh -- /usr/bin/true ... W: [FAILED] kernel is tainted I: [OK] /usr/bin/true I: results: [OK] 1 [SKIPPED] 0 [FAILED] 0 [TOTAL] 1 Now: $ ./tests/shell/run-tests.sh -- /usr/bin/true ... W: kernel is tainted I: [OK] /usr/bin/true I: results: [OK] 1 [SKIPPED] 0 [FAILED] 0 [TOTAL] 1 Signed-off-by: Thomas Haller Signed-off-by: Florian Westphal --- diff --git a/tests/shell/run-tests.sh b/tests/shell/run-tests.sh index 4c1ab29b..6abb6c0c 100755 --- a/tests/shell/run-tests.sh +++ b/tests/shell/run-tests.sh @@ -496,7 +496,8 @@ check_kmemleak() read kernel_tainted < /proc/sys/kernel/tainted if [ "$kernel_tainted" -ne 0 ] ; then - msg_warn "[FAILED] kernel is tainted" + msg_warn "kernel is tainted" + echo fi print_test_header() {