From: Greg Kroah-Hartman Date: Mon, 13 Mar 2023 11:25:38 +0000 (+0100) Subject: 4.19-stable patches X-Git-Tag: v4.14.310~94 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a552443fd67561f51c5d91b9c11c222b7b505a30;p=thirdparty%2Fkernel%2Fstable-queue.git 4.19-stable patches added patches: nfc-change-order-inside-nfc_se_io-error-path.patch --- diff --git a/queue-4.19/nfc-change-order-inside-nfc_se_io-error-path.patch b/queue-4.19/nfc-change-order-inside-nfc_se_io-error-path.patch new file mode 100644 index 00000000000..bd0dbd87dfe --- /dev/null +++ b/queue-4.19/nfc-change-order-inside-nfc_se_io-error-path.patch @@ -0,0 +1,38 @@ +From 7d834b4d1ab66c48e8c0810fdeadaabb80fa2c81 Mon Sep 17 00:00:00 2001 +From: Fedor Pchelkin +Date: Tue, 7 Mar 2023 00:26:50 +0300 +Subject: nfc: change order inside nfc_se_io error path + +From: Fedor Pchelkin + +commit 7d834b4d1ab66c48e8c0810fdeadaabb80fa2c81 upstream. + +cb_context should be freed on the error path in nfc_se_io as stated by +commit 25ff6f8a5a3b ("nfc: fix memory leak of se_io context in +nfc_genl_se_io"). + +Make the error path in nfc_se_io unwind everything in reverse order, i.e. +free the cb_context after unlocking the device. + +Suggested-by: Krzysztof Kozlowski +Signed-off-by: Fedor Pchelkin +Reviewed-by: Krzysztof Kozlowski +Link: https://lore.kernel.org/r/20230306212650.230322-1-pchelkin@ispras.ru +Signed-off-by: Jakub Kicinski +Signed-off-by: Greg Kroah-Hartman +--- + net/nfc/netlink.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +--- a/net/nfc/netlink.c ++++ b/net/nfc/netlink.c +@@ -1464,8 +1464,8 @@ static int nfc_se_io(struct nfc_dev *dev + return rc; + + error: +- kfree(cb_context); + device_unlock(&dev->dev); ++ kfree(cb_context); + return rc; + } + diff --git a/queue-4.19/series b/queue-4.19/series index 9602537eede..740022bd6ca 100644 --- a/queue-4.19/series +++ b/queue-4.19/series @@ -5,3 +5,4 @@ ext4-fix-another-off-by-one-fsmap-error-on-1k-block-filesystems.patch ext4-move-where-set-the-may_inline_data-flag-is-set.patch ext4-fix-warning-in-ext4_update_inline_data.patch ext4-zero-i_disksize-when-initializing-the-bootloader-inode.patch +nfc-change-order-inside-nfc_se_io-error-path.patch