From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Mon, 22 May 2017 14:17:46 +0000 (+0200)
Subject: ref_update_reject_duplicates(): use `size_t` rather than `int`
X-Git-Tag: v2.14.0-rc0~109^2~9
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a552e50e5a82b9219c6b2911320931417a36af32;p=thirdparty%2Fgit.git

ref_update_reject_duplicates(): use `size_t` rather than `int`

Eliminate a theoretical risk of integer overflow if the two types have
different sizes.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/refs.c b/refs.c
index beb49fb297..143936a9c3 100644
--- a/refs.c
+++ b/refs.c
@@ -1705,7 +1705,7 @@ int create_symref(const char *ref_target, const char *refs_heads_master,
 int ref_update_reject_duplicates(struct string_list *refnames,
 				 struct strbuf *err)
 {
-	int i, n = refnames->nr;
+	size_t i, n = refnames->nr;
 
 	assert(err);