From: Simon Marchi <simon.marchi@efficios.com>
Date: Tue, 28 Apr 2020 18:29:39 +0000 (-0400)
Subject: gdb: fix shellcheck warning in update-freebsd.sh
X-Git-Tag: binutils-2_35~945
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a55e30b51bc6227d8d41f707654d0a5620978dcf;p=thirdparty%2Fbinutils-gdb.git

gdb: fix shellcheck warning in update-freebsd.sh

shellcheck reports:

    In update-freebsd.sh line 72:
    }' $1 >> freebsd.xml.tmp
       ^-- SC2086: Double quote to prevent globbing and word splitting.

    Did you mean:
    }' "$1" >> freebsd.xml.tmp

    For more information:
      https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

Add double quotes to fix it.

gdb/ChangeLog:

	* syscalls/update-freebsd.sh: Add double quotes.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index bd2c9b030ab..81983103ac2 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
+
+	* syscalls/update-freebsd.sh: Add double quotes.
+
 2020-04-28  Tom Tromey  <tom@tromey.com>
 
 	* NEWS: Update.
diff --git a/gdb/syscalls/update-freebsd.sh b/gdb/syscalls/update-freebsd.sh
index 7b177f31151..5d9602641b4 100755
--- a/gdb/syscalls/update-freebsd.sh
+++ b/gdb/syscalls/update-freebsd.sh
@@ -69,7 +69,7 @@ awk '
 }
 /\/\* [0-9]* is freebsd[0-9]* [a-z_]* \*\// {
     printf "  <syscall name=\"%s_%s\" number=\"%s\" alias=\"%s\"/>\n", $4, $5, $2, $5
-}' $1 >> freebsd.xml.tmp
+}' "$1" >> freebsd.xml.tmp
 
 cat >> freebsd.xml.tmp <<EOF
 </syscalls_info>