From: Christoph Hellwig <hch@lst.de>
Date: Thu, 5 Jun 2025 06:16:28 +0000 (+0200)
Subject: xfs: remove NULL pointer checks in xfs_mru_cache_insert
X-Git-Tag: v6.16-rc5~30^2~12
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a593c89ac5a417605b165cbc9768b3663ab4d8ad;p=thirdparty%2Fkernel%2Flinux.git

xfs: remove NULL pointer checks in xfs_mru_cache_insert

Remove the check for a NULL mru or mru->list in xfs_mru_cache_insert
as this API misused lead to a direct NULL pointer dereference on first
use and is not user triggerable.  As a smatch run by Dan points out
with the recent cleanup it would otherwise try to free the object we
just determined to be NULL for this impossible to reach case.

Fixes: 70b95cb86513 ("xfs: free the item in xfs_mru_cache_insert on failure")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hans Holmberg <hans.holmberg@wdc.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
---

diff --git a/fs/xfs/xfs_mru_cache.c b/fs/xfs/xfs_mru_cache.c
index 08443ceec329d..c95401de8397d 100644
--- a/fs/xfs/xfs_mru_cache.c
+++ b/fs/xfs/xfs_mru_cache.c
@@ -425,10 +425,6 @@ xfs_mru_cache_insert(
 {
 	int			error = -EINVAL;
 
-	ASSERT(mru && mru->lists);
-	if (!mru || !mru->lists)
-		goto out_free;
-
 	error = -ENOMEM;
 	if (radix_tree_preload(GFP_KERNEL))
 		goto out_free;