From: Timo Sirainen <tss@iki.fi>
Date: Wed, 18 Nov 2015 18:50:55 +0000 (+0200)
Subject: stats: Improved logging on invalid CONNECT input.
X-Git-Tag: 2.2.20.rc1~56
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a5b6819fac1ecf8c1369a85c47fec7dd468aefe0;p=thirdparty%2Fdovecot%2Fcore.git

stats: Improved logging on invalid CONNECT input.
---

diff --git a/src/stats/mail-session.c b/src/stats/mail-session.c
index 8d20637939..947e23f7f8 100644
--- a/src/stats/mail-session.c
+++ b/src/stats/mail-session.c
@@ -84,13 +84,16 @@ int mail_session_connect_parse(const char *const *args, const char **error_r)
 	}
 	session_id = args[0];
 	if (str_to_pid(args[3], &pid) < 0) {
-		*error_r = "CONNECT: Invalid pid";
+		*error_r = t_strdup_printf("CONNECT: Invalid pid %s for session ID %s",
+					   args[3], session_id);
 		return -1;
 	}
 
 	session = hash_table_lookup(mail_sessions_hash, session_id);
 	if (session != NULL) {
-		*error_r = "CONNECT: Duplicate session ID";
+		*error_r = t_strdup_printf(
+			"CONNECT: Duplicate session ID %s for user %s service %s",
+			session_id, args[1], args[2]);
 		return -1;
 	}
 	session = i_malloc(sizeof(struct mail_session) + stats_alloc_size());