From: George Thessalonikefs <george@nlnetlabs.nl>
Date: Mon, 31 Jan 2022 10:27:35 +0000 (+0100)
Subject: -Fix review comment for use-after-free when failing to send UDP out.
X-Git-Tag: release-1.15.0rc1~17
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a60bbd12ed90fec3ee41fb112234bb481b2f6e79;p=thirdparty%2Funbound.git

-Fix review comment for use-after-free when failing to send UDP out.
---

diff --git a/doc/Changelog b/doc/Changelog
index 9b9dd0557..534987789 100644
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -1,3 +1,6 @@
+31 January 2022: George
+	- Fix review comment for use-after-free when failing to send UDP out.
+
 29 January 2022: George
 	- Fix tls-* and ssl-* documented alternate syntax to also be available
 	  through remote-control and unbound-checkconf.
diff --git a/services/outside_network.c b/services/outside_network.c
index 651f221fd..eff7758c4 100644
--- a/services/outside_network.c
+++ b/services/outside_network.c
@@ -1384,8 +1384,9 @@ outnet_send_wait_udp(struct outside_network* outnet)
 					NETEVENT_CLOSED, NULL);
 			}
 			pending_delete(outnet, pend);
+		} else {
+			pend->sq->busy = 0;
 		}
-		pend->sq->busy = 0;
 	}
 }