From: Emanuele Giuseppe Esposito Date: Fri, 3 Sep 2021 11:38:00 +0000 (+0200) Subject: include/block.h: remove outdated comment X-Git-Tag: v6.2.0-rc0~69^2~12 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a6297e1ade6d9981c4a8d43eb426830b49a7913c;p=thirdparty%2Fqemu.git include/block.h: remove outdated comment There are a couple of errors in bdrv_drained_begin header comment: - block_job_pause does not exist anymore, it has been replaced with job_pause in b15de82867 - job_pause is automatically invoked as a .drained_begin callback (child_job_drained_begin) by the child_job BdrvChildClass struct in blockjob.c. So no additional pause should be required. Signed-off-by: Emanuele Giuseppe Esposito Message-Id: <20210903113800.59970-1-eesposit@redhat.com> Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- diff --git a/include/block/block.h b/include/block/block.h index 740038a8920..ab987e8a997 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -751,9 +751,7 @@ bool bdrv_drain_poll(BlockDriverState *bs, bool recursive, * bdrv_drained_begin: * * Begin a quiesced section for exclusive access to the BDS, by disabling - * external request sources including NBD server and device model. Note that - * this doesn't block timers or coroutines from submitting more requests, which - * means block_job_pause is still necessary. + * external request sources including NBD server, block jobs, and device model. * * This function can be recursive. */