From: Michael Tremer <michael.tremer@ipfire.org>
Date: Sun, 15 Sep 2024 02:36:36 +0000 (+0000)
Subject: buildservice: Tidy up creating the daemon control connection
X-Git-Tag: 0.9.30~1201
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a66066db7383225d853847a1306791bffdfb64ab;p=pakfire.git

buildservice: Tidy up creating the daemon control connection

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/buildservice.c b/src/libpakfire/buildservice.c
index a4fcc70e0..fa5291897 100644
--- a/src/libpakfire/buildservice.c
+++ b/src/libpakfire/buildservice.c
@@ -1027,16 +1027,10 @@ ERROR:
 int pakfire_buildservice_daemon(struct pakfire_buildservice* service, pakfire_xfer_recv_callback recv,
 		pakfire_xfer_send_callback send, pakfire_xfer_close_callback close, void* data) {
 	struct pakfire_xfer* xfer = NULL;
-	char url[PATH_MAX];
 	int r;
 
-	// Compose the URL
-	r = pakfire_string_set(url, "/api/v1/builders/control");
-	if (r)
-		goto ERROR;
-
 	// Create a new xfer
-	r = pakfire_buildservice_create_xfer(&xfer, service, url);
+	r = pakfire_buildservice_create_xfer(&xfer, service, "/api/v1/builders/control");
 	if (r)
 		goto ERROR;
 
@@ -1055,6 +1049,11 @@ int pakfire_buildservice_daemon(struct pakfire_buildservice* service, pakfire_xf
 	if (r)
 		goto ERROR;
 
+	return 0;
+
 ERROR:
+	if (xfer)
+		pakfire_xfer_unref(xfer);
+
 	return r;
 }