From: Alexander Kanavin Date: Fri, 6 Jun 2025 08:59:48 +0000 (+0200) Subject: lib/oeqa/utils/sshcontrol: correct condition for ending the select() loop X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a6690deffd7ddbce0e784701ea3fdbb84313b009;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git lib/oeqa/utils/sshcontrol: correct condition for ending the select() loop This was set backwards; per https://docs.python.org/3/library/subprocess.html#subprocess.Popen.returncode a return code of None indicates the process is still running, and so the code entered a busyloop that ended on timeout 5 minutes later, lengthening selftests significantly. Signed-off-by: Alexander Kanavin Signed-off-by: Richard Purdie --- diff --git a/meta/lib/oeqa/utils/sshcontrol.py b/meta/lib/oeqa/utils/sshcontrol.py index 6c5648779a..88a61aff63 100644 --- a/meta/lib/oeqa/utils/sshcontrol.py +++ b/meta/lib/oeqa/utils/sshcontrol.py @@ -58,7 +58,7 @@ class SSHProcess(object): data = os.read(self.process.stdout.fileno(), 1024) if not data: self.process.poll() - if self.process.returncode is None: + if self.process.returncode is not None: self.process.stdout.close() eof = True else: