From: Jeff King Date: Tue, 20 Aug 2024 05:18:19 +0000 (-0400) Subject: t-hashmap: stop calling setup() for t_intern() test X-Git-Tag: v2.47.0-rc0~94^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a6bcb3ca010ed47d26dfa5d5d221f91a46887c2f;p=thirdparty%2Fgit.git t-hashmap: stop calling setup() for t_intern() test Commit f24a9b78a9 (t-hashmap: mark unused parameters in callback function, 2024-08-17) noted that the t_intern() does not need its hashmap parameter, but we have to keep it to conform to the function pointer interface of setup(). But since the only thing setup() does is create and tear down the hashmap, we can just skip calling setup() entirely for this case, and drop the unused parameters. This simplifies the code a bit. Helped-by: Ghanshyam Thakkar Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/t/unit-tests/t-hashmap.c b/t/unit-tests/t-hashmap.c index da102eb541..83b79dff39 100644 --- a/t/unit-tests/t-hashmap.c +++ b/t/unit-tests/t-hashmap.c @@ -322,8 +322,7 @@ static void t_alloc(struct hashmap *map, unsigned int ignore_case) free(removed); } -static void t_intern(struct hashmap *map UNUSED, - unsigned int ignore_case UNUSED) +static void t_intern(void) { const char *values[] = { "value1", "Value1", "value2", "value2" }; @@ -357,6 +356,6 @@ int cmd_main(int argc UNUSED, const char **argv UNUSED) TEST(setup(t_iterate, 0), "iterate works"); TEST(setup(t_iterate, 1), "iterate (case insensitive) works"); TEST(setup(t_alloc, 0), "grow / shrink works"); - TEST(setup(t_intern, 0), "string interning works"); + TEST(t_intern(), "string interning works"); return test_done(); }