From: Zachary Ware <zachary.ware@gmail.com>
Date: Tue, 26 Nov 2013 20:50:10 +0000 (-0600)
Subject: Issue #19588: Fixed tests in test_random that were silently skipped most
X-Git-Tag: v3.4.0b2~463^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a6edea530bb9f3a9ff6234f443ea5d00428a7635;p=thirdparty%2FPython%2Fcpython.git

Issue #19588: Fixed tests in test_random that were silently skipped most
of the time.  Patch by Julian Gindi.
---

diff --git a/Lib/test/test_random.py b/Lib/test/test_random.py
index facddb1ebd89..d363a6a1d15a 100644
--- a/Lib/test/test_random.py
+++ b/Lib/test/test_random.py
@@ -194,10 +194,10 @@ class SystemRandom_TestBasicOps(TestBasicOps, unittest.TestCase):
 
     def test_bigrand_ranges(self):
         for i in [40,80, 160, 200, 211, 250, 375, 512, 550]:
-            start = self.gen.randrange(2 ** i)
-            stop = self.gen.randrange(2 ** (i-2))
+            start = self.gen.randrange(2 ** (i-2))
+            stop = self.gen.randrange(2 ** i)
             if stop <= start:
-                return
+                continue
             self.assertTrue(start <= self.gen.randrange(start, stop) < stop)
 
     def test_rangelimits(self):
@@ -357,10 +357,10 @@ class MersenneTwister_TestBasicOps(TestBasicOps, unittest.TestCase):
 
     def test_bigrand_ranges(self):
         for i in [40,80, 160, 200, 211, 250, 375, 512, 550]:
-            start = self.gen.randrange(2 ** i)
-            stop = self.gen.randrange(2 ** (i-2))
+            start = self.gen.randrange(2 ** (i-2))
+            stop = self.gen.randrange(2 ** i)
             if stop <= start:
-                return
+                continue
             self.assertTrue(start <= self.gen.randrange(start, stop) < stop)
 
     def test_rangelimits(self):
diff --git a/Misc/ACKS b/Misc/ACKS
index 5b0f8b045b98..39b0f704d130 100644
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -435,6 +435,7 @@ Dinu Gherman
 Jonathan Giddy
 Johannes Gijsbers
 Michael Gilfix
+Julian Gindi
 Yannick Gingras
 Matt Giuca
 Wim Glenn
diff --git a/Misc/NEWS b/Misc/NEWS
index 84217e7b2188..f488230dad94 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -65,6 +65,9 @@ Library
 Tests
 -----
 
+- Issue #19588: Fixed tests in test_random that were silently skipped most
+  of the time.  Patch by Julian Gindi.
+
 - Issue #19596: Set untestable tests in test_importlib to None to avoid
   reporting success on empty tests.