From: Tim Duesterhus <tim@bastelstu.be>
Date: Sat, 8 Oct 2022 10:33:19 +0000 (+0200)
Subject: CLEANUP: Reapply strcmp.cocci
X-Git-Tag: v2.7-dev8~58
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a6fc616c1acb636d999b6d3dd2c066263c0b756d;p=thirdparty%2Fhaproxy.git

CLEANUP: Reapply strcmp.cocci

This reapplies strcmp.cocci across the whole src/ tree.
---

diff --git a/src/cfgparse-quic.c b/src/cfgparse-quic.c
index 5268e9adaf..f6706f2e0d 100644
--- a/src/cfgparse-quic.c
+++ b/src/cfgparse-quic.c
@@ -26,9 +26,9 @@ static int bind_parse_quic_cc_algo(char **args, int cur_arg, struct proxy *px,
 		return ERR_ALERT | ERR_FATAL;
 	}
 
-	if (!strcmp(args[cur_arg + 1], "newreno"))
+	if (strcmp(args[cur_arg + 1], "newreno") == 0)
 	    cc_algo = &quic_cc_algo_nr;
-	else if (!strcmp(args[cur_arg + 1], "cubic"))
+	else if (strcmp(args[cur_arg + 1], "cubic") == 0)
 	    cc_algo = &quic_cc_algo_cubic;
 	else {
 		memprintf(err, "'%s' : unknown control congestion algorithm", args[cur_arg]);
diff --git a/src/flt_bwlim.c b/src/flt_bwlim.c
index e3d3c0dc09..203f91d370 100644
--- a/src/flt_bwlim.c
+++ b/src/flt_bwlim.c
@@ -419,7 +419,7 @@ int check_bwlim_action(struct act_rule *rule, struct proxy *px, char **err)
 		conf = NULL;
 		if (fconf->id == bwlim_flt_id) {
 			conf = fconf->conf;
-			if (!strcmp(rule->arg.act.p[0], conf->name))
+			if (strcmp(rule->arg.act.p[0], conf->name) == 0)
 				break;
 		}
 	}
@@ -639,7 +639,7 @@ static int parse_bwlim_flt(char **args, int *cur_arg, struct proxy *px, struct f
 		if (fc->id == bwlim_flt_id) {
 			struct bwlim_config *c = fc->conf;
 
-			if (!strcmp(conf->name, c->name)) {
+			if (strcmp(conf->name, c->name) == 0) {
 				memprintf(err, "bwlim filter '%s' already declared for proxy '%s'\n",
 					  conf->name, px->id);
 				goto error;