From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Sun, 5 Mar 2017 00:01:55 +0000 (+0300)
Subject: net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump
X-Git-Tag: v4.10.5~32
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a6ff06211b846bc812b22f0c2422bd5bbc41ec83;p=thirdparty%2Fkernel%2Fstable.git

net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump

[ Upstream commit 6c4dc75c251721f517e9daeb5370ea606b5b35ce ]

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/net/sched/act_skbmod.c b/net/sched/act_skbmod.c
index 3b7074e230248..c736627f8f4a0 100644
--- a/net/sched/act_skbmod.c
+++ b/net/sched/act_skbmod.c
@@ -228,7 +228,6 @@ static int tcf_skbmod_dump(struct sk_buff *skb, struct tc_action *a,
 
 	return skb->len;
 nla_put_failure:
-	rcu_read_unlock();
 	nlmsg_trim(skb, b);
 	return -1;
 }