From: Alain Volmat Date: Wed, 3 Jul 2024 11:59:16 +0000 (+0200) Subject: media: stm32: dcmipp: correct error handling in dcmipp_create_subdevs X-Git-Tag: v6.11-rc1~142^2~6 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a7351f0d3668b449fdc2cfd90403b1cb1f03ed6d;p=thirdparty%2Fkernel%2Flinux.git media: stm32: dcmipp: correct error handling in dcmipp_create_subdevs Correct error handling within the dcmipp_create_subdevs by properly decrementing the i counter when releasing the subdevs. Fixes: 28e0f3772296 ("media: stm32-dcmipp: STM32 DCMIPP camera interface driver") Cc: stable@vger.kernel.org Signed-off-by: Alain Volmat Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus [hverkuil: correct the indices: it's [i], not [i - 1].] --- diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c index 4acc3b90d03aa..7f771ea49b784 100644 --- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c +++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c @@ -202,8 +202,8 @@ static int dcmipp_create_subdevs(struct dcmipp_device *dcmipp) return 0; err_init_entity: - while (i > 0) - dcmipp->pipe_cfg->ents[i - 1].release(dcmipp->entity[i - 1]); + while (i-- > 0) + dcmipp->pipe_cfg->ents[i].release(dcmipp->entity[i]); return ret; }