From: Alejandro Colomar <alx@kernel.org>
Date: Fri, 17 May 2024 11:14:31 +0000 (+0200)
Subject: src/useradd.c: De-duplicate code
X-Git-Tag: 4.15.2~28
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a74c4b6ae124a55cd272e574e0d056102f331e17;p=thirdparty%2Fshadow.git

src/useradd.c: De-duplicate code

Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

diff --git a/src/useradd.c b/src/useradd.c
index 6a3edfe3b..ad2676c1c 100644
--- a/src/useradd.c
+++ b/src/useradd.c
@@ -571,14 +571,13 @@ static int set_defaults (void)
 	}
 
 	ret = mkdir(dirname(new_file_dup), 0755);
+	free(new_file_dup);
 	if (-1 == ret && EEXIST != errno) {
 		fprintf (stderr,
 			_("%s: cannot create directory for defaults file\n"),
 			Prog);
-		free(new_file_dup);
 		goto err_free_def;
 	}
-	free(new_file_dup);
 
 	/*
 	 * Create a temporary file to copy the new output to.