From: Neil Horman <nhorman@openssl.org>
Date: Mon, 15 Jul 2024 19:59:14 +0000 (-0400)
Subject: Fix coverity-1604665
X-Git-Tag: openssl-3.4.0-alpha1~329
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a753547eefc9739f341824a0cb0642afe7a06fcc;p=thirdparty%2Fopenssl.git

Fix coverity-1604665

Coverity issued an error in the opt_uintmax code, detecting a potential
overflow on a cast to ossl_intmax_t

Looks like it was just a typo, casting m from uintmax_t to ossl_intmax_t

Fix it by correcting the cast to be ossl_uintmax_t, as would be expected

Theres also some conditionals that seem like they should be removed, but
I'll save that for later, as there may be some corner cases in which
ossl_uintmax_t isn't equal in size to uintmax_t..maybe.

Fixes openssl/private#567

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24897)
---

diff --git a/apps/lib/opt.c b/apps/lib/opt.c
index 0490c39c251..d72b624a9e5 100644
--- a/apps/lib/opt.c
+++ b/apps/lib/opt.c
@@ -646,7 +646,7 @@ int opt_uintmax(const char *value, ossl_uintmax_t *result)
         opt_number_error(value);
         return 0;
     }
-    *result = (ossl_intmax_t)m;
+    *result = (ossl_uintmax_t)m;
     errno = oerrno;
     return 1;
 }