From: Valentin Schneider Date: Wed, 27 Nov 2024 16:55:01 +0000 (+0100) Subject: sched/fair: Remove CONFIG_CFS_BANDWIDTH=n definition of cfs_bandwidth_used() X-Git-Tag: v6.14-rc1~184^2~42 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a76328d44c7ab7d1001a97cb2e84506dde7822d4;p=thirdparty%2Fkernel%2Flinux.git sched/fair: Remove CONFIG_CFS_BANDWIDTH=n definition of cfs_bandwidth_used() Andy reported that clang gets upset with CONFIG_CFS_BANDWIDTH=n: kernel/sched/fair.c:6580:20: error: unused function 'cfs_bandwidth_used' [-Werror,-Wunused-function] 6580 | static inline bool cfs_bandwidth_used(void) | ^~~~~~~~~~~~~~~~~~ Indeed, cfs_bandwidth_used() is only used within functions defined under CONFIG_CFS_BANDWIDTH=y. Remove its CONFIG_CFS_BANDWIDTH=n declaration & definition. Reported-by: Andy Shevchenko Signed-off-by: Valentin Schneider Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20241127165501.160004-1-vschneid@redhat.com --- diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 05b8f1eb2c149..4283c818bbd19 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -5373,8 +5373,6 @@ place_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags) static void check_enqueue_throttle(struct cfs_rq *cfs_rq); static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq); -static inline bool cfs_bandwidth_used(void); - static void requeue_delayed_entity(struct sched_entity *se); @@ -6748,11 +6746,6 @@ static void sched_fair_update_stop_tick(struct rq *rq, struct task_struct *p) #else /* CONFIG_CFS_BANDWIDTH */ -static inline bool cfs_bandwidth_used(void) -{ - return false; -} - static void account_cfs_rq_runtime(struct cfs_rq *cfs_rq, u64 delta_exec) {} static bool check_cfs_rq_runtime(struct cfs_rq *cfs_rq) { return false; } static void check_enqueue_throttle(struct cfs_rq *cfs_rq) {}