From: Andrew Goodbody <andrew.goodbody@linaro.org>
Date: Fri, 4 Jul 2025 12:32:42 +0000 (+0100)
Subject: fs: ext4fs: Do not negate error before returning it
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a7e44898b4d2484a9fd3226f44bc9b51d174f1e3;p=thirdparty%2Fu-boot.git

fs: ext4fs: Do not negate error before returning it

In ext4fs_readdir it calls ext4fs_read_file and checks the return value
for non-zero to detect an error. This return value should be returned as
is rather than being negated.

This issue found by Smatch

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
---

diff --git a/fs/ext4/ext4fs.c b/fs/ext4/ext4fs.c
index 1727da2dc6d..7fb4c1b755b 100644
--- a/fs/ext4/ext4fs.c
+++ b/fs/ext4/ext4fs.c
@@ -272,7 +272,7 @@ int ext4fs_readdir(struct fs_dir_stream *fs_dirs, struct fs_dirent **dentp)
 				       sizeof(struct ext2_dirent),
 				       (char *)&dirent, &actread);
 		if (ret < 0)
-			return -ret;
+			return ret;
 
 		if (!dirent.direntlen)
 			return -EIO;