From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Wed, 25 Jan 2017 22:29:03 +0000 (-0700)
Subject: Complain about malformed 64bit header values, not the valid ones.
X-Git-Tag: M-staged-PR71~297
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a7fea967e5e8385c438aed2fdfe5f3bd9c43d2dc;p=thirdparty%2Fsquid.git

Complain about malformed 64bit header values, not the valid ones.

I added this regression in r14819, apparently confused by my own
unfortunate "bad is true" httpHeaderNoteParsedEntry(error) API.
---

diff --git a/src/HttpHeader.cc b/src/HttpHeader.cc
index 8b5fdb8543..85f5126b7c 100644
--- a/src/HttpHeader.cc
+++ b/src/HttpHeader.cc
@@ -1513,7 +1513,7 @@ HttpHeaderEntry::getInt64() const
 {
     int64_t val = -1;
     const bool ok = httpHeaderParseOffset(value.termedBuf(), &val);
-    httpHeaderNoteParsedEntry(id, value, ok);
+    httpHeaderNoteParsedEntry(id, value, !ok);
     return val; // remains -1 if !ok (XXX: bad method API)
 }