From: Frank Ch. Eigler Date: Thu, 15 Apr 2021 10:29:01 +0000 (-0400) Subject: debuginfod: only update database stats once per groom X-Git-Tag: elfutils-0.184~8 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a81366e011f686ca4a907673801fb4902a7e790c;p=thirdparty%2Felfutils.git debuginfod: only update database stats once per groom On very large servers, each database-stat counting pass can take tens of minutes (!), and doing it twice per groom pass does not seriously improve data quality. Just do it once, after stale data removal & basic sqlite vacuum. Signed-off-by: Frank Ch. Eigler --- diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog index 3bd2ff606..ed2f77cfa 100644 --- a/debuginfod/ChangeLog +++ b/debuginfod/ChangeLog @@ -1,3 +1,7 @@ +2021-04-15 Frank Ch. Eigler + + * debuginfod.cxx (groom): Only update database stats once. + 2021-04-15 Frank Ch. Eigler * debuginfod.cxx (elf_classify): Recognize symtab-only stripped files diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx index 2d73a136a..50777f1fa 100644 --- a/debuginfod/debuginfod.cxx +++ b/debuginfod/debuginfod.cxx @@ -3100,8 +3100,6 @@ void groom() struct timespec ts_start, ts_end; clock_gettime (CLOCK_MONOTONIC, &ts_start); - database_stats_report(); - // scan for files that have disappeared sqlite_ps files (db, "check old files", "select s.mtime, s.file, f.name from " BUILDIDS "_file_mtime_scanned s, " BUILDIDS "_files f "