From: Andy Shevchenko Date: Fri, 9 Oct 2020 18:08:56 +0000 (+0300) Subject: pinctrl: mcp23s08: Print error message when regmap init fails X-Git-Tag: v5.10-rc4~22^2~6 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a835d3a114ab0dc2f0d8c6963c3f53734b1c5965;p=thirdparty%2Fkernel%2Flinux.git pinctrl: mcp23s08: Print error message when regmap init fails It is useful for debugging to have the error message printed when regmap initialisation fails. Add it to the driver. Signed-off-by: Andy Shevchenko Cc: Martin Hundebøll Link: https://lore.kernel.org/r/20201009180856.4738-2-andriy.shevchenko@linux.intel.com Tested-by: Jan Kundrát Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/pinctrl-mcp23s08_spi.c b/drivers/pinctrl/pinctrl-mcp23s08_spi.c index 7c72cffe14127..9ae10318f6f35 100644 --- a/drivers/pinctrl/pinctrl-mcp23s08_spi.c +++ b/drivers/pinctrl/pinctrl-mcp23s08_spi.c @@ -126,6 +126,8 @@ static int mcp23s08_spi_regmap_init(struct mcp23s08 *mcp, struct device *dev, copy->name = name; mcp->regmap = devm_regmap_init(dev, &mcp23sxx_spi_regmap, mcp, copy); + if (IS_ERR(mcp->regmap)) + dev_err(dev, "regmap init failed for %s\n", mcp->chip.label); return PTR_ERR_OR_ZERO(mcp->regmap); }