From: Frédéric Lécaille Date: Fri, 19 Aug 2022 10:08:13 +0000 (+0200) Subject: MINOR: quic: Trace fix in qc_release_frm() X-Git-Tag: v2.7-dev4~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a846a17fdea6004e6bbbb77a1d016b4542714851;p=thirdparty%2Fhaproxy.git MINOR: quic: Trace fix in qc_release_frm() This wrong trace came with this commit: "BUG/MINOR: quic: Possible crashes when dereferencing ->pkt quic_frame struct member" In qc_release_frm() we mark frames as acked. Nothing to see with references to frames. Thank you to Willy for having caught this one. Must be backported to 2.6 as these traces arrived with a bug fix to be backported to 2.6. --- diff --git a/src/xprt_quic.c b/src/xprt_quic.c index baee8e242b..9c42e524b2 100644 --- a/src/xprt_quic.c +++ b/src/xprt_quic.c @@ -1510,7 +1510,7 @@ void qc_release_frm(struct quic_conn *qc, struct quic_frame *frm) } else { /* XXX TODO: what must be done for such a frame */ - TRACE_DEVEL("remove frame reference for unsent frame", + TRACE_DEVEL("mark frame as acked for unsent frame", QUIC_EV_CONN_PRSAFRM, qc, f); } f->flags |= QUIC_FL_TX_FRAME_ACKED;