From: Chao Yu Date: Wed, 29 Jul 2020 13:21:35 +0000 (+0800) Subject: f2fs: compress: add sanity check during compressed cluster read X-Git-Tag: v5.9-rc1~69^2~5 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a86d27dd3dbed4d870c6582b8d4bf1fd0f653914;p=thirdparty%2Fkernel%2Flinux.git f2fs: compress: add sanity check during compressed cluster read In f2fs_read_multi_pages(), we don't have to check cluster's type again, since overwrite or partial truncation need page lock in cluster which has already been held by reader, so cluster's type is stable, let's change check condition to sanity check. Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim --- diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index bc89bc987513e..c1b676be67b9a 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -2170,9 +2170,7 @@ int f2fs_read_multi_pages(struct compress_ctx *cc, struct bio **bio_ret, if (ret) goto out; - /* cluster was overwritten as normal cluster */ - if (dn.data_blkaddr != COMPRESS_ADDR) - goto out; + f2fs_bug_on(sbi, dn.data_blkaddr != COMPRESS_ADDR); for (i = 1; i < cc->cluster_size; i++) { block_t blkaddr;