From: Colin Ian King Date: Fri, 12 Jan 2018 16:47:50 +0000 (-0800) Subject: xfs: fix check on struct_version for versions 4 or greater X-Git-Tag: v4.16-rc1~143^2~47 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a8789a5ae28f69d7f3791a0e74f8c44222f3108b;p=thirdparty%2Flinux.git xfs: fix check on struct_version for versions 4 or greater It appears that the check for versions 4 or more is incorrect and is off-by-one. Fix this. Detected by CoverityScan, CID#1463775 ("Logically dead code") Fixes: ac503a4cc9e8 ("xfs: refactor the geometry structure filling function") Signed-off-by: Colin Ian King Reviewed-by: Darrick J. Wong Signed-off-by: Darrick J. Wong --- diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c index 35b005d66977f..869a2f3f03752 100644 --- a/fs/xfs/libxfs/xfs_sb.c +++ b/fs/xfs/libxfs/xfs_sb.c @@ -951,7 +951,7 @@ xfs_fs_geometry( geo->rtsectsize = sbp->sb_blocksize; geo->dirblocksize = xfs_dir2_dirblock_bytes(sbp); - if (struct_version < 3) + if (struct_version < 4) return 0; if (xfs_sb_version_haslogv2(sbp))