From: Jouni Malinen <jouni@codeaurora.org>
Date: Fri, 6 Dec 2019 22:39:46 +0000 (+0200)
Subject: SAE: Reject invalid rejected group report in SAE commit explicitly (AP)
X-Git-Tag: hostap_2_10~2179
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a889e9a70c7d0ec563dc24df02319194e971979e;p=thirdparty%2Fhostap.git

SAE: Reject invalid rejected group report in SAE commit explicitly (AP)

Previously, this case was ignored silently in AP mode. While that could
be a reasonable approach for an unexpected condition, it would be fine
to reject this case explicitly as well. This makes it somewhat easier to
test unexpected SAE H2E vs. looping behavior.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
---

diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c
index c10ae12ee..38199e048 100644
--- a/src/ap/ieee802_11.c
+++ b/src/ap/ieee802_11.c
@@ -1282,7 +1282,7 @@ static void handle_auth_sae(struct hostapd_data *hapd, struct sta_info *sta,
 		    check_sae_rejected_groups(
 			    hapd, sta->sae->tmp->peer_rejected_groups)) {
 			resp = WLAN_STATUS_UNSPECIFIED_FAILURE;
-			goto remove_sta;
+			goto reply;
 		}
 
 		if (!token && use_sae_anti_clogging(hapd) && !allow_reuse) {