From: Jaroslav Kysela Date: Fri, 5 Jul 2024 07:58:28 +0000 (+0200) Subject: ALSA: pcm: Fix id copying in snd_pcm_set_sync_per_card() X-Git-Tag: v6.11-rc1~108^2~9^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a892b700e63bcb3679ebed1a0c3160e7b9225138;p=thirdparty%2Fkernel%2Flinux.git ALSA: pcm: Fix id copying in snd_pcm_set_sync_per_card() Avoid to use strncpy and do proper length limiting (12 bytes) to avoid out of array access. Fixes: d712c58c55d9 ("ALSA: pcm: optimize and clarify stream synchronization ID API") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202407050501.o5Z3bibi-lkp@intel.com/ Signed-off-by: Jaroslav Kysela Link: https://patch.msgid.link/20240705075828.19746-1-perex@perex.cz Signed-off-by: Takashi Iwai --- diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c index 66683656fb13e..6e7905749c4a3 100644 --- a/sound/core/pcm_lib.c +++ b/sound/core/pcm_lib.c @@ -543,8 +543,8 @@ void snd_pcm_set_sync_per_card(struct snd_pcm_substream *substream, const unsigned char *id, unsigned int len) { *(__u32 *)params->sync = cpu_to_le32(substream->pcm->card->number); - len = max(12, len); - strncpy(params->sync + 4, id, len); + len = min(12, len); + memcpy(params->sync + 4, id, len); memset(params->sync + 4 + len, 0, 12 - len); } EXPORT_SYMBOL_GPL(snd_pcm_set_sync_per_card);