From: Pavel Hrdina <phrdina@redhat.com>
Date: Thu, 6 Mar 2025 11:00:13 +0000 (+0100)
Subject: domain_conf: graphics: extract Desktop formatting to separate function
X-Git-Tag: v11.2.0-rc1~245
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a93ea4cd84da622604a133c92daa6c7d6238c781;p=thirdparty%2Flibvirt.git

domain_conf: graphics: extract Desktop formatting to separate function

virDomainGraphicsDefFormat function was way too long so split it into
separate functions for each graphics type.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 3587abc24a..c66cdfc1a2 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -26531,6 +26531,16 @@ virDomainGraphicsDefFormatRDP(virBuffer *attrBuf,
     virDomainGraphicsListenDefFormatAddr(attrBuf, glisten, flags);
 }
 
+static void
+virDomainGraphicsDefFormatDesktop(virBuffer *attrBuf,
+                                  virDomainGraphicsDef *def)
+{
+    virBufferEscapeString(attrBuf, " display='%s'", def->data.desktop.display);
+
+    if (def->data.desktop.fullscreen)
+        virBufferAddLit(attrBuf, " fullscreen='yes'");
+}
+
 static int
 virDomainGraphicsDefFormat(virBuffer *buf,
                            virDomainGraphicsDef *def,
@@ -26565,12 +26575,7 @@ virDomainGraphicsDefFormat(virBuffer *buf,
         break;
 
     case VIR_DOMAIN_GRAPHICS_TYPE_DESKTOP:
-        virBufferEscapeString(&attrBuf, " display='%s'",
-                              def->data.desktop.display);
-
-        if (def->data.desktop.fullscreen)
-            virBufferAddLit(&attrBuf, " fullscreen='yes'");
-
+        virDomainGraphicsDefFormatDesktop(&attrBuf, def);
         break;
 
     case VIR_DOMAIN_GRAPHICS_TYPE_SPICE: