From: Bruce Momjian <bruce@momjian.us>
Date: Wed, 10 Oct 2012 17:53:00 +0000 (-0400)
Subject: In pg_upgrade, issue proper error message when we can't open PG_VERSION.
X-Git-Tag: REL9_3_BETA1~799
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a9701a1d7df8c7a088ed7c37316fe4118a507015;p=thirdparty%2Fpostgresql.git

In pg_upgrade, issue proper error message when we can't open PG_VERSION.

Backpatch to 9.2.
---

diff --git a/contrib/pg_upgrade/server.c b/contrib/pg_upgrade/server.c
index 11e7e75d78f..a9f9d85b787 100644
--- a/contrib/pg_upgrade/server.c
+++ b/contrib/pg_upgrade/server.c
@@ -149,7 +149,7 @@ get_major_server_version(ClusterInfo *cluster)
 	snprintf(ver_filename, sizeof(ver_filename), "%s/PG_VERSION",
 			 cluster->pgdata);
 	if ((version_fd = fopen(ver_filename, "r")) == NULL)
-		return 0;
+		pg_log(PG_FATAL, "could not open version file: %s\n", ver_filename);
 
 	if (fscanf(version_fd, "%63s", cluster->major_version_str) == 0 ||
 		sscanf(cluster->major_version_str, "%d.%d", &integer_version,