From: Michal Privoznik <mprivozn@redhat.com>
Date: Wed, 14 May 2025 13:46:16 +0000 (+0200)
Subject: virnetdevvlan: Fix return type of virNetDevVlanEqual()
X-Git-Tag: v11.4.0-rc1~72
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a9adca09569c26ec18df47fc684e96ea2efa966b;p=thirdparty%2Flibvirt.git

virnetdevvlan: Fix return type of virNetDevVlanEqual()

The virNetDevVlanEqual() function is declared to return an int
but in fact its return type is a boolean. Even its only caller
(qemuDomainChangeNet()) treats its retval as a boolean. Switch
the return type from integer to boolean.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/util/virnetdevvlan.c b/src/util/virnetdevvlan.c
index b0e05d8ffe..453b8d0ac9 100644
--- a/src/util/virnetdevvlan.c
+++ b/src/util/virnetdevvlan.c
@@ -41,7 +41,7 @@ virNetDevVlanFree(virNetDevVlan *vlan)
     g_free(vlan);
 }
 
-int
+bool
 virNetDevVlanEqual(const virNetDevVlan *a, const virNetDevVlan *b)
 {
     int ai, bi;
diff --git a/src/util/virnetdevvlan.h b/src/util/virnetdevvlan.h
index fd2f8023f5..59f7fa523d 100644
--- a/src/util/virnetdevvlan.h
+++ b/src/util/virnetdevvlan.h
@@ -41,7 +41,7 @@ struct _virNetDevVlan {
 
 void virNetDevVlanClear(virNetDevVlan *vlan);
 void virNetDevVlanFree(virNetDevVlan *vlan);
-int virNetDevVlanEqual(const virNetDevVlan *a, const virNetDevVlan *b);
+bool virNetDevVlanEqual(const virNetDevVlan *a, const virNetDevVlan *b);
 void virNetDevVlanCopy(virNetDevVlan *dst, const virNetDevVlan *src);
 
 G_DEFINE_AUTOPTR_CLEANUP_FUNC(virNetDevVlan, virNetDevVlanFree);