From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Sun, 5 Nov 2017 08:42:03 +0000 (+0100)
Subject: ref_transaction_update(): die on disallowed flags
X-Git-Tag: v2.16.0-rc0~132^2~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a9bbbcec0d863d719dd4ae39fc2242b32c2008e7;p=thirdparty%2Fgit.git

ref_transaction_update(): die on disallowed flags

Callers shouldn't be passing disallowed flags into
`ref_transaction_update()`. So instead of masking them off, treat it
as a bug if any are set.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/refs.c b/refs.c
index 62a7621025..7c1e206e08 100644
--- a/refs.c
+++ b/refs.c
@@ -940,7 +940,8 @@ int ref_transaction_update(struct ref_transaction *transaction,
 		return -1;
 	}
 
-	flags &= REF_TRANSACTION_UPDATE_ALLOWED_FLAGS;
+	if (flags & ~REF_TRANSACTION_UPDATE_ALLOWED_FLAGS)
+		BUG("illegal flags 0x%x passed to ref_transaction_update()", flags);
 
 	flags |= (new_oid ? REF_HAVE_NEW : 0) | (old_oid ? REF_HAVE_OLD : 0);