From: Andy Shevchenko Date: Thu, 5 Nov 2020 11:05:28 +0000 (+0200) Subject: platform/x86: i2c-multi-instantiate: Simplify with dev_err_probe() X-Git-Tag: v5.11-rc1~154^2~34 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a9d1c25004820b1fa7dcd99626ad5c73e023fb6d;p=thirdparty%2Flinux.git platform/x86: i2c-multi-instantiate: Simplify with dev_err_probe() Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20201105110530.27888-2-andriy.shevchenko@linux.intel.com Signed-off-by: Hans de Goede --- diff --git a/drivers/platform/x86/i2c-multi-instantiate.c b/drivers/platform/x86/i2c-multi-instantiate.c index d92d9a98ec8f0..ce4d921c3301b 100644 --- a/drivers/platform/x86/i2c-multi-instantiate.c +++ b/drivers/platform/x86/i2c-multi-instantiate.c @@ -118,9 +118,8 @@ static int i2c_multi_inst_probe(struct platform_device *pdev) } multi->clients[i] = i2c_acpi_new_device(dev, i, &board_info); if (IS_ERR(multi->clients[i])) { - ret = PTR_ERR(multi->clients[i]); - if (ret != -EPROBE_DEFER) - dev_err(dev, "Error creating i2c-client, idx %d\n", i); + ret = dev_err_probe(dev, PTR_ERR(multi->clients[i]), + "Error creating i2c-client, idx %d\n", i); goto error; } }