From: Tom de Vries <tdevries@suse.de>
Date: Fri, 26 Sep 2025 23:20:56 +0000 (+0200)
Subject: [gdb/testsuite] Declare TUI tests unsupported on msys2-ucrt64
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=aa0b6c104791cbc11a110ce8911f2859ca15b793;p=thirdparty%2Fbinutils-gdb.git

[gdb/testsuite] Declare TUI tests unsupported on msys2-ucrt64

I tried to run the TUI tests on msys2-ucrt64, and ran into:
...
(gdb) tui enable^M
Cannot enable the TUI when output is not a terminal^M
(gdb)
...

The TUI works fine in an msys2-ucrt64 terminal, it's just the testsuite setup
that doesn't work.

Fix this by bailing out for istarget *-*-mingw* in allow_tui_tests.

Tested on x86_64-linux and msys2-ucrt64.

Approved-By: Tom Tromey <tom@tromey.com>

PR testsuite/33362
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33362
---

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index f05e1c84d5b..94978504a5b 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -3122,6 +3122,10 @@ gdb_caching_proc allow_dlmopen_tests {} {
 # Return 1 if we should allow TUI-related tests.
 
 gdb_caching_proc allow_tui_tests {} {
+    if { [istarget *-*-mingw*] } {
+	# Avoid "Cannot enable the TUI when output is not a terminal".
+	return 0
+    }
     set output [remote_exec host $::GDB "$::INTERNAL_GDBFLAGS --configuration"]
     return [expr {[string first "--enable-tui" $output] != -1}]
 }