From: Michal Privoznik Date: Wed, 2 Oct 2013 16:18:13 +0000 (+0200) Subject: qemuMonitorJSONSendKey: Avoid double free X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=aa24b068fd7d4b822ab2c198074dccfc9e9c949b;p=thirdparty%2Flibvirt.git qemuMonitorJSONSendKey: Avoid double free After successful @cmd construction the memory where @keys points to is part of @cmd. Avoid double freeing it. (cherry picked from commit 3e8343e1510741623aa5bc1dfb74ec39fde868dd) --- diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 12f7e69115..27e72ab8b5 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -3454,6 +3454,9 @@ int qemuMonitorJSONSendKey(qemuMonitorPtr mon, if (!cmd) goto cleanup; + /* @keys is part of @cmd now. Avoid double free */ + keys = NULL; + if ((ret = qemuMonitorJSONCommand(mon, cmd, &reply)) < 0) goto cleanup;