From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 25 Mar 2025 13:51:25 +0000 (+0100)
Subject: virDomainStorageNetworkParseHost: Remove unpopulated 'transport' variable
X-Git-Tag: v11.3.0-rc1~98
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=aa3c1de26061bd70e3c38ea42feea5d5cb8aac67;p=thirdparty%2Flibvirt.git

virDomainStorageNetworkParseHost: Remove unpopulated 'transport' variable

Since the refactor to use proper enum type for the network transport the
'transport' variable is no longer filled. Remove it and fix the error
message which references it without using NULLSTR.

Fixes: 452695926dc
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 99ecb03067..53ab502306 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -6017,7 +6017,6 @@ virDomainStorageNetworkParseHost(xmlNodePtr hostnode,
                                  virStorageNetHostDef *host)
 {
     int ret = -1;
-    g_autofree char *transport = NULL;
     g_autofree char *port = NULL;
 
     memset(host, 0, sizeof(*host));
@@ -6043,7 +6042,7 @@ virDomainStorageNetworkParseHost(xmlNodePtr hostnode,
         host->socket != NULL) {
         virReportError(VIR_ERR_XML_ERROR,
                        _("transport '%1$s' does not support socket attribute"),
-                       transport);
+                       virStorageNetHostTransportTypeToString(host->transport));
         goto cleanup;
     }